mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fsl TSEC: register map boundary
Date: Tue, 11 Sep 2012 10:06:20 +0200	[thread overview]
Message-ID: <20120911080620.GN18243@pengutronix.de> (raw)
In-Reply-To: <1347276084-20145-1-git-send-email-renaud.barbier@ge.com>

On Mon, Sep 10, 2012 at 12:21:24PM +0100, Renaud Barbier wrote:
> The end boundary of each registers set may overlap with the start
> of the next register set. Subtract 1 to the end boundary.
> 
> Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>

Applied, thanks

Sascha

> ---
>  arch/ppc/mach-mpc85xx/eth-devices.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/ppc/mach-mpc85xx/eth-devices.c b/arch/ppc/mach-mpc85xx/eth-devices.c
> index 02a3722..c6e8f36 100644
> --- a/arch/ppc/mach-mpc85xx/eth-devices.c
> +++ b/arch/ppc/mach-mpc85xx/eth-devices.c
> @@ -32,15 +32,15 @@ int fsl_eth_init(int num, struct gfar_info_struct *gf)
>  	res = xzalloc(3 * sizeof(struct resource));
>  	/* TSEC interface registers */
>  	res[0].start = GFAR_BASE_ADDR + ((num - 1) * 0x1000);
> -	res[0].end = res[0].start + 0x1000;
> +	res[0].end = res[0].start + 0x1000 - 1;
>  	res[0].flags = IORESOURCE_MEM;
>  	/* External PHY access always through eTSEC1 */
>  	res[1].start = MDIO_BASE_ADDR;
> -	res[1].end = res[1].start + 0x1000;
> +	res[1].end = res[1].start + 0x1000 - 1;
>  	res[1].flags = IORESOURCE_MEM;
>  	/* Access to TBI/RTBI interface. */
>  	res[2].start = MDIO_BASE_ADDR + ((num - 1) * 0x1000);
> -	res[2].end = res[2].start + 0x1000;
> +	res[2].end = res[2].start + 0x1000 - 1;
>  	res[2].flags = IORESOURCE_MEM;
>  
>  	add_generic_device_res("gfar", DEVICE_ID_DYNAMIC, res, 3, gf);
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-09-11  8:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 11:21 Renaud Barbier
2012-09-11  8:06 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911080620.GN18243@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=renaud.barbier@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox