From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/5] I2C: Put I2C devices on their own bus
Date: Tue, 11 Sep 2012 16:04:55 +0200 [thread overview]
Message-ID: <20120911140455.GL31207@game.jcrosoft.org> (raw)
In-Reply-To: <1347370313-15184-4-git-send-email-s.hauer@pengutronix.de>
On 15:31 Tue 11 Sep , Sascha Hauer wrote:
> This patch adds a I2C bus on which the I2C devices and drivers register.
> This makes it cleaner as I2C devices won't accidently end up probed by
> a platform_device driver.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/i2c/i2c.c | 23 +++++++++++++++++++++++
> drivers/mfd/lp3972.c | 2 +-
> drivers/mfd/mc13xxx.c | 2 +-
> drivers/mfd/mc34704.c | 4 ++--
> drivers/mfd/mc34708.c | 2 +-
> drivers/mfd/mc9sdz60.c | 2 +-
> drivers/mfd/stmpe-i2c.c | 2 +-
> drivers/mfd/twl4030.c | 2 +-
> drivers/mfd/twl6030.c | 2 +-
> include/i2c/i2c.h | 8 ++++++++
> 10 files changed, 40 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c
> index 3af2b3e..555722b 100644
> --- a/drivers/i2c/i2c.c
> +++ b/drivers/i2c/i2c.c
> @@ -251,6 +251,7 @@ struct i2c_client *i2c_new_device(struct i2c_adapter *adapter,
> strcpy(client->dev.name, chip->type);
> client->dev.type_data = client;
> client->dev.platform_data = chip->platform_data;
> + client->dev.bus = &i2c_bus;
> client->adapter = adapter;
> client->addr = chip->addr;
>
> @@ -372,3 +373,25 @@ int i2c_add_numbered_adapter(struct i2c_adapter *adapter)
> return 0;
> }
> EXPORT_SYMBOL(i2c_add_numbered_adapter);
> +
> +static int i2c_match(struct device_d *dev, struct driver_d *drv)
> +{
> + return strcmp(dev->name, drv->name) ? -1 : 0;
can we check the address too here
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-11 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 13:31 [PATCH] device/driver work Sascha Hauer
2012-09-11 13:31 ` [PATCH 1/5] mfd mc13xxx: Separate I2C and SPI probe Sascha Hauer
2012-09-11 13:31 ` [PATCH 2/5] SPI: Put SPI devices on their own bus bus Sascha Hauer
2012-09-11 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-11 14:26 ` Sascha Hauer
2012-09-11 13:31 ` [PATCH 3/5] I2C: Put I2C devices on their own bus Sascha Hauer
2012-09-11 14:04 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-11 14:27 ` Sascha Hauer
2012-09-11 15:56 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-11 16:10 ` Sascha Hauer
2012-09-11 17:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 6:47 ` Sascha Hauer
2012-09-11 13:31 ` [PATCH 4/5] driver: rewrite dev_printf as a function Sascha Hauer
2012-09-11 13:31 ` [PATCH 5/5] driver: Add platform_device_id mechanism Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911140455.GL31207@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox