From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]) by casper.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TC3at-0007NL-CR for barebox@lists.infradead.org; Thu, 13 Sep 2012 07:12:12 +0000 Date: Thu, 13 Sep 2012 09:12:03 +0200 From: Sascha Hauer Message-ID: <20120913071203.GD6180@pengutronix.de> References: <20120912142743.GR31207@game.jcrosoft.org> <1347461308-24208-1-git-send-email-plagnioj@jcrosoft.com> <1347461308-24208-6-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1347461308-24208-6-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 6/7] dhcp: add retries limit support To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Wed, Sep 12, 2012 at 04:48:27PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > via -r opt, global.dhcp.retries or dhcp_retries > > set the priority order; > > This will allow to do not stay infinite loop if no dhcp availlable s/availlable/available/ > @@ -746,11 +767,17 @@ static int do_dhcp(int argc, char *argv[]) > while (dhcp_state != BOUND) { > if (ctrlc()) > break; > + if (!retries) { > + ret = ETIMEDOUT; -ETIMEDOUT BTW currently we have in most commands: return ret ? 1 : 0; This is because the shell interpreted negative values as 'exit'. hush does not do this anymore, so now we can think about a path to just return negative error codes from the commands. > @@ -785,7 +812,8 @@ BAREBOX_CMD_HELP_OPT ("-u ", > BAREBOX_CMD_HELP_OPT ("-U ", > "DHCP User class (code 77) submitted in DHCP requests. It can\n" > "be used in the DHCP server's configuration to select options\n" > -"(e.g. bootfile or server) which are valid for barebox clients only.\n"); > +"(e.g. bootfile or server) which are valid for barebox clients only.\n") > +BAREBOX_CMD_HELP_OPT ("-r ", "retry limi\n"); s/limi/limit/ Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox