mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/2] P2020RDB eTSEC2
Date: Fri, 14 Sep 2012 09:33:36 +0200	[thread overview]
Message-ID: <20120914073336.GU6180@pengutronix.de> (raw)
In-Reply-To: <1347558111-1633-1-git-send-email-renaud.barbier@ge.com>

Hi Renaud,

On Thu, Sep 13, 2012 at 06:41:49PM +0100, Renaud Barbier wrote:
> This patch set updates the gianfar driver and enables the port eTSEC2
> of the P2020RDB. Both eTSEC2 and eTSEC3 can be used.
> Also it has been noticed that dev_request_mem_region returns NULL when
> a region is already mapped. Some of the registers set may be the same between
> or within driver instances. This patch sorts out the conflict in region
> request.

That's not nice to have conflicting resources. The best solution would
be to register the phy independently of the network device and just use
the phy in the driver instead of registering it.
I see that with the current (generic network, mii) code this does not
work. Jean-Christophe currently works on phylib support which could
improve the situation somewhat. It may still not be possible to do what
you have to, but your patches will need adjustments to phylib anyway.

Could have have a look at it? I asked Jean-Christophe for sending the
phylib support again, and I think it can be merged then.

Thanks
 Sascha



-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2012-09-14  7:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 17:41 Renaud Barbier
2012-09-13 17:41 ` [PATCH 1/2] gianfar: region request returns NULL on already mapped region Renaud Barbier
2012-09-13 17:41 ` [PATCH 2/2] P2020rdb: eTSEC2 support Renaud Barbier
2012-09-14  7:33 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914073336.GU6180@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=renaud.barbier@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox