From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mo5.mail-out.ovh.net ([178.32.228.5]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TCRvX-0003y4-Hn for barebox@lists.infradead.org; Fri, 14 Sep 2012 09:11:08 +0000 Received: from mail404.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo5.mail-out.ovh.net (Postfix) with SMTP id BA104FFAD00 for ; Fri, 14 Sep 2012 11:12:43 +0200 (CEST) Date: Fri, 14 Sep 2012 11:04:29 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120914090429.GB25990@game.jcrosoft.org> References: <20120914071804.GR6180@pengutronix.de> <20120914072536.GS6180@pengutronix.de> <20120914074437.GE20834@game.jcrosoft.org> <20120914085001.GA25990@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC][FAT] Handle MBR on the first sector To: Franck Jullien Cc: barebox On 11:02 Fri 14 Sep , Franck Jullien wrote: > > 2012/9/14 Jean-Christophe PLAGNIOL-VILLARD : > > > > On 10:47 Fri 14 Sep , Franck Jullien wrote: > >> > >> 2012/9/14 Jean-Christophe PLAGNIOL-VILLARD : > >> > > >> > On 09:25 Fri 14 Sep , Sascha Hauer wrote: > >> >> > >> >> On Fri, Sep 14, 2012 at 09:22:07AM +0200, Franck Jullien wrote: > >> >> > 2012/9/14 Sascha Hauer : > >> >> > > Hi Franck, > >> >> > > > >> >> > > On Thu, Sep 13, 2012 at 02:13:29PM +0200, Franck Jullien wrote: > >> >> > >> *** Did not send this email with git because it's no working where I am ** > >> >> > >> > >> >> > >> We may have some disk with MBR as a first sector. In this case, the > >> >> > >> current FAT check returns an error. However, the FAT sector exist and > >> >> > >> the MBR can tell us where it is. > >> >> > >> > >> >> > >> This patch make the FAT fs try to find the FAT boot sector on the first > >> >> > >> sector of the first partition in case it is not on sector 0. > >> >> > > > >> >> > > The patch looks good. Not applying it because it's RFC, but I would if > >> >> > > you give your ok. > >> >> > > > >> >> > > >> >> > You have it. > >> >> > >> >> Thanks, applied > >> > > >> > Does this work with the fat autodetection > >> > > >> > Best Regards, > >> > J. > >> > >> What do you mean ? > >> > >> It works when you mount your device as FAT. The FAT fs check is the > >> first sector is FAT boot sector. If not, it suppose it is an MBR and > >> the FAT boot sector is in the first partition. > > check the the next branch > > > > I add the fs detection to do not specify the filesystem type anymore in mount > > > > Best Regards, > > J. > > It won't. We need to check if it is an MBR here too (static int > is_fat(u8 *buf)) .... please fix it there too Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox