From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TDAuW-0007AM-8l for barebox@lists.infradead.org; Sun, 16 Sep 2012 09:13:05 +0000 Date: Sun, 16 Sep 2012 11:13:02 +0200 From: Sascha Hauer Message-ID: <20120916091302.GH6180@pengutronix.de> References: <20120914073755.GD20834@game.jcrosoft.org> <1347609426-21286-1-git-send-email-plagnioj@jcrosoft.com> <20120916081139.GZ24458@pengutronix.de> <20120916082813.GE25990@game.jcrosoft.org> <20120916083410.GF6180@pengutronix.de> <20120916090224.GG25990@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120916090224.GG25990@game.jcrosoft.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/3] net: introduce phylib To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Sun, Sep 16, 2012 at 11:02:24AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:34 Sun 16 Sep , Sascha Hauer wrote: > > On Sun, Sep 16, 2012 at 10:28:13AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 10:11 Sun 16 Sep , Sascha Hauer wrote: > > > > On Fri, Sep 14, 2012 at 09:57:04AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > > > > > > Adapt phylib from linux > > > > > > > > > > switch all the driver to it > > > > > > > > > > This will allow to have > > > > > - phy drivers > > > > > - to only connect the phy at then opening of the device > > > > > - if the phy is not ready fail on open > > > > > > > > > > Same behaviour as in linux and will allow to share code and simplify porting. > > > > > > > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > > > > --- > > > > > > > > [...] > > > > > > > > + > > > > > +/* Automatically gets and returns the PHY device */ > > > > > +int phy_device_connect(struct mii_device *bus, int addr, > > > > > + void (*adjust_link) (struct mii_device *miidev)) > > > > > > > > The prototype of adjust_link seems wrong. A mii_device is a mii bus with > > > > potentially multiple phys. adjust_link should work on the phy_device. With > > > > the above, when a mii_device has multiple phys, a network driver has no > > > > way to figure out which phy has an updated link. > > > > > > > > This probably bites Renaud who has a single mii bus for multiple network > > > > devices. > > > not really as the phydev have a bus field so will be the same > > > > Renaud has two phys on the same mii bus, so when he is passed a struct > > mii_device, how can he get a pointer to his network device? He can't. > as I said just after we should attached the phy to eth_device not mii_device Once again: from fec_imx.c: static void fec_update_linkspeed(struct mii_device *mdev) { struct eth_device *edev = mdev->edev; ... } How will you get a pointer to edev once a mii_device has multiple phys, potentially connected to different network devices? > > so he will have one phy per eth_device Yes, but multiple eth_devices per mii_device. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox