From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TDLyb-0007PN-Mb for barebox@lists.infradead.org; Sun, 16 Sep 2012 21:02:02 +0000 Date: Sun, 16 Sep 2012 23:01:58 +0200 From: Sascha Hauer Message-ID: <20120916210158.GL6180@pengutronix.de> References: <20120916124223.GK25990@game.jcrosoft.org> <1347818098-10408-1-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1347818098-10408-1-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/1] net: introduce phylib To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Sun, Sep 16, 2012 at 07:54:58PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > Adapt phylib from linux > > switch all the driver to it > > This will allow to have > - phy drivers > - to only connect the phy at then opening of the device > - if the phy is not ready or not up fail on open > > Same behaviour as in linux and will allow to share code and simplify porting. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > +/* Automatically gets and returns the PHY device */ > +int phy_device_connect(struct mii_device *bus, int addr, > + void (*adjust_link) (struct eth_device *edev), > + u32 flags, phy_interface_t interface) > +{ > + struct eth_device *edev = bus->edev; You should pass in a struct eth_device pointer here instead of getting it from bus->edev because a struct mii_device can have multiple ethernet devices. The next step would be to remove the edev member from struct mii_dev and add it to struct phy_device insted. BTW no typedefs please. Use enum phy_interface instead. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox