Re: [PATCH 1/1] net: introduce phylib

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 20:07 Sun 16 Sep     , Sascha Hauer wrote:
> On Sun, Sep 16, 2012 at 03:45:08PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Adapt phylib from linux
> > 
> > switch all the driver to it
> > 
> > This will allow to have
> >  - phy drivers
> >  - to only connect the phy at then opening of the device
> >  - if the phy is not ready or not up fail on open
> > 
> > Same behaviour as in linux and will allow to share code and simplify porting.
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
>  config:     ppc              pcm030_defconfig
> drivers/net/fec_mpc5200.c: In function 'mpc5xxx_fec_open':
> drivers/net/fec_mpc5200.c:415:15: error: 'mpc5xxx_fec_priv' has no member named 'phy_flags'
> drivers/net/fec_mpc5200.c:415:31: error: 'mpc5xxx_fec_priv' has no member named 'interface'
> drivers/net/fec_mpc5200.c: In function 'mpc5xxx_fec_probe':
> drivers/net/fec_mpc5200.c:687:8: error: 'RMII' undeclared (first use in this function)
> drivers/net/fec_mpc5200.c:687:8: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/fec_mpc5200.c:688:7: error: 'mpc5xxx_fec_priv' has no member named 'interface'
> drivers/net/fec_mpc5200.c:690:8: error: 'RGMII' undeclared (first use in this function)
> drivers/net/fec_mpc5200.c:691:7: error: 'mpc5xxx_fec_priv' has no member named 'interface'
> drivers/net/fec_mpc5200.c:694:7: error: 'mpc5xxx_fec_priv' has no member named 'phy_flags'
> drivers/net/fec_mpc5200.c:696:7: error: 'mpc5xxx_fec_priv' has no member named 'interface'
> drivers/net/fec_mpc5200.c:699:7: error: 'mpc5xxx_fec_priv' has no member named 'interface'
> make[2]: *** [drivers/net/fec_mpc5200.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
> make: *** Waiting for unfinished jobs....
we really need to cleanup this driver to share code with teh arm one instead
of copy and paste everywhere

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox