From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TDc5I-0005xN-Gv for barebox@lists.infradead.org; Mon, 17 Sep 2012 14:14:01 +0000 Date: Mon, 17 Sep 2012 16:13:36 +0200 From: Sascha Hauer Message-ID: <20120917141336.GB24458@pengutronix.de> References: <20120917054332.GO25990@game.jcrosoft.org> <1347861568-20072-1-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1347861568-20072-1-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/1] net: introduce phylib To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Mon, Sep 17, 2012 at 07:59:28AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > Adapt phylib from linux > > switch all the driver to it > > This will allow to have > - phy drivers > - to only connect the phy at then opening of the device > - if the phy is not ready or not up fail on open > > Same behaviour as in linux and will allow to share code and simplify porting. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- [...] > +/* Automatically gets and returns the PHY device */ > +int phy_device_connect(struct eth_device *edev, struct mii_device *bus, int addr, > + void (*adjust_link) (struct eth_device *edev), > + u32 flags, phy_interface_t interface) > +{ > + struct phy_driver* drv; > + struct phy_device* dev = NULL; > + unsigned int i; > + int ret = -EINVAL; > + > + if (!edev->phydev) { > + if (addr >= 0) { > + dev = get_phy_device(bus, addr); > + if (IS_ERR(dev)) { > + ret = PTR_ERR(dev); > + goto fail; > + } > + > + dev->attached_dev = edev; > + dev->interface = interface; > + dev->dev_flags = flags; > + > + ret = register_device(&dev->dev); > + if (ret) > + goto fail; > + } else { > + for (i = 0; i < PHY_MAX_ADDR && !edev->phydev; i++) { > + dev = get_phy_device(bus, i); > + if (IS_ERR(dev)) > + continue; > + > + dev->attached_dev = edev; > + dev->interface = interface; > + dev->dev_flags = flags; > + > + ret = register_device(&dev->dev); > + if (ret) > + goto fail; > + } > + > + if (i == 32) { > + ret = -EIO; > + goto fail; > + } I just found out the hard way that this does not work with a phy_id of 31. I don't know exactly the intention of this code, but I would just test for !edev->phydev instead of i==32. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox