From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck Jullien <franck.jullien@gmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] [v3] filetype: Improve FAT detection
Date: Wed, 19 Sep 2012 09:36:45 +0200 [thread overview]
Message-ID: <20120919073645.GY6180@pengutronix.de> (raw)
In-Reply-To: <CAJfOKBxCdWAO+WitmFdUwWYzBWoEPiNiy_wV+c0fe57daMSQBA@mail.gmail.com>
On Wed, Sep 19, 2012 at 09:23:19AM +0200, Franck Jullien wrote:
> 2012/9/19 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Tue, Sep 18, 2012 at 11:51:35PM +0200, Franck Jullien wrote:
> >> We may have some disk with MBR as a first sector. In this case, the
> >> current FAT check returns an error. However, the FAT sector exist and
> >> the MBR can tell us where it is.
> >>
> >> This patch add to file_name_detect_type function the ability to find
> >> the FAT boot sector on the first sector of the first partition in case
> >> it is not on sector 0.
> >>
> >> It also introduce is_fat_or_mbr to check if a buffer is a FAT boot
> >> or MBR sector
> >>
> >> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> >> ---
> >> common/filetype.c | 63 ++++++++++++++++++++++++++++++++++++++++++----------
> >> include/filetype.h | 2 +
> >> 2 files changed, 53 insertions(+), 12 deletions(-)
> >>
[...]
>
> I shouldn't write code late at night. Hopefully you are reading my
> code with attention :)
Don't worry, I think this happens to most of us ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-19 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 21:51 Franck Jullien
2012-09-18 21:51 ` [PATCH 2/2] [v2] fs/fat: Handle MBR on the first sector Franck Jullien
2012-09-19 7:12 ` [PATCH 1/2] [v3] filetype: Improve FAT detection Sascha Hauer
2012-09-19 7:23 ` Franck Jullien
2012-09-19 7:36 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919073645.GY6180@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox