Re: [PATCH 1/2] Add bcm2835/Raspberry-Pi support

[Juergen Beisert <jbe@pengutronix.de>]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:42 Wed 19 Sep     , Juergen Beisert wrote:
> > Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > [...]
> > >
> > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > > index a54ad03..f8eb1b4 100644
> > > > --- a/arch/arm/Kconfig
> > > > +++ b/arch/arm/Kconfig
> > > > @@ -92,6 +92,11 @@ config ARCH_TEGRA
> > > >  	select CPU_ARM926T
> > > >  	select HAS_DEBUG_LL
> > > >
> > > > +config ARCH_BCM2835
> > > > +	bool "Broadcom BCM2835 boards"
> > > > +	select GENERIC_GPIO
> > > > +	select CPU_ARM1176
> > >
> > > please keep in alphabetic order
> >
> > What a useless rule...
>
> no when you search for something you expect b to be after a not after z

In Kconfig and Makefiles? Sorry. How often do your search for something in 
these kind of files?

And how often do you search for something in the C-sources?

So, what is important and what is useless?

"Some people unfortunately like jumping up and down about spaces but not code.
[...]  I'd rather read good poetry written in very bad hand writing than bad
poetry written in beautiful handwriting, and I think the same is true of code.
           -- Alan Cox <20090701130018.115ce0ea@lxorguk.ukuu.org.uk>"

Still just my 2ct.

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-5121-206917-5128 |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox