From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TEwoV-0004F7-Th for barebox@lists.infradead.org; Fri, 21 Sep 2012 06:34:13 +0000 Date: Fri, 21 Sep 2012 08:34:08 +0200 From: Sascha Hauer Message-ID: <20120921063408.GC1322@pengutronix.de> References: <1348158669-14034-1-git-send-email-renaud.barbier@ge.com> <1348158669-14034-2-git-send-email-renaud.barbier@ge.com> <20120920182332.GD26553@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120920182332.GD26553@game.jcrosoft.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/5] phylib: bus reset function To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Thu, Sep 20, 2012 at 08:23:32PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:31 Thu 20 Sep , Renaud Barbier wrote: > > Added an entry point for a bus reset function. > > > > Signed-off-by: Renaud Barbier > > --- > > drivers/net/phy/phy.c | 3 +++ > > include/miidev.h | 1 + > > 2 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > > index 5406ea3..d9f5409 100644 > > --- a/drivers/net/phy/phy.c > > +++ b/drivers/net/phy/phy.c > > @@ -129,6 +129,9 @@ int phy_device_connect(struct eth_device *edev, struct mii_device *bus, int addr > > unsigned int i; > > int ret = -EINVAL; > > > > + if (bus->reset) > > + bus->reset(bus); > > + > I do not like this we should not touch the bus at phy connect Then please make a suggestion where it should be then. I also have some drivers where this function could be used. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox