From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] phylib: bus reset function
Date: Fri, 21 Sep 2012 10:06:58 +0200 [thread overview]
Message-ID: <20120921080658.GL26553@game.jcrosoft.org> (raw)
In-Reply-To: <20120921063408.GC1322@pengutronix.de>
On 08:34 Fri 21 Sep , Sascha Hauer wrote:
> On Thu, Sep 20, 2012 at 08:23:32PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 17:31 Thu 20 Sep , Renaud Barbier wrote:
> > > Added an entry point for a bus reset function.
> > >
> > > Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
> > > ---
> > > drivers/net/phy/phy.c | 3 +++
> > > include/miidev.h | 1 +
> > > 2 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> > > index 5406ea3..d9f5409 100644
> > > --- a/drivers/net/phy/phy.c
> > > +++ b/drivers/net/phy/phy.c
> > > @@ -129,6 +129,9 @@ int phy_device_connect(struct eth_device *edev, struct mii_device *bus, int addr
> > > unsigned int i;
> > > int ret = -EINVAL;
> > >
> > > + if (bus->reset)
> > > + bus->reset(bus);
> > > +
> > I do not like this we should not touch the bus at phy connect
>
> Then please make a suggestion where it should be then. I also have some
> drivers where this function could be used.
I have too the need of a reset
I get a big issue on reset the mii bus at eth open
my only idea was to move the phy detect awqy from the eth_open to the mii bus
probe
but this will increase the boot time as we do not need to probe the phy if we
do not use the network
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-21 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 16:31 [PATCH 0/5] gianfar: mdio bus support Renaud Barbier
2012-09-20 16:31 ` [PATCH 1/5] phylib: bus reset function Renaud Barbier
2012-09-20 18:23 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-21 6:34 ` Sascha Hauer
2012-09-21 8:06 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-21 8:30 ` Sascha Hauer
2012-09-21 17:04 ` Renaud Barbier
2012-09-21 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 16:31 ` [PATCH 2/5] FSL mdio bus support Renaud Barbier
2012-09-20 18:27 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 16:31 ` [PATCH 3/5] gianfar update Renaud Barbier
2012-09-20 18:30 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 16:31 ` [PATCH 4/5] FSL mdio: configuration and build file Renaud Barbier
2012-09-20 16:31 ` [PATCH 5/5] P2020rdb: eTSEC2 support Renaud Barbier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921080658.GL26553@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox