mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org, Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH 1/5] video: add atmel lcdc frambuffer support
Date: Sun, 23 Sep 2012 13:00:00 +0200	[thread overview]
Message-ID: <20120923110000.GJ1322@pengutronix.de> (raw)
In-Reply-To: <1348338408-26737-1-git-send-email-plagnioj@jcrosoft.com>

On Sat, Sep 22, 2012 at 08:26:44PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> This IP is present on the at91sam9 until the sam9g45, on the sam9x5 we use a
> new IP.
> 
> This driver is based on the linux one.
> 
> +
> +/* Way LCD wires are connected to the chip:
> + * Some Atmel chips use BGR color mode (instead of standard RGB)
> + * A swapped wiring onboard can bring to RGB mode.
> + */
> +#define ATMEL_LCDC_WIRING_BGR	0
> +#define ATMEL_LCDC_WIRING_RGB	1
> +#define ATMEL_LCDC_WIRING_RGB555	2
> +
> +
> + /* LCD Controller info data structure, stored in device platform_data */
> +struct atmel_lcdfb_info {
> +	struct fb_info		*info;
> +	void __iomem		*mmio;
> +	struct device_d		*device;
> +
> +	unsigned int		guard_time;
> +	unsigned int		smem_len;
> +	struct clk		*bus_clk;
> +	struct clk		*lcdc_clk;
> +
> +	bool			lcdcon_is_backlight;
> +	bool			lcdcon_pol_negative;
> +	u8			saved_lcdcon;
> +
> +	u8			default_bpp;
> +	u8			lcd_wiring_mode;
> +	unsigned int		default_lcdcon2;
> +	unsigned int		default_dmacon;
> +	void (*atmel_lcdfb_power_control)(int on);
> +	struct fb_videomode	*mode_list;
> +	unsigned		num_modes;
> +	u32			pseudo_palette[16];
> +};

Honestly, Passing in the driver internal data as platform_data is completely
rubbish. If you want to have it the-same-like-in-Linux, then fix it in Linux
first.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-09-23 11:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-22 17:53 [PATCH 0/5 v2] at91 framebuffer support Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 18:26 ` [PATCH 1/5] video: add atmel lcdc frambuffer support Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 18:26   ` [PATCH 2/5] at91sam9263: " Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 18:26   ` [PATCH 3/5] at91sam9261: " Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 18:26   ` [PATCH 4/5] at91sam9g45: " Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 18:26   ` [PATCH 5/5] at91sam9m10g45ek: add lcdc support Jean-Christophe PLAGNIOL-VILLARD
2012-09-25  8:09     ` Sascha Hauer
2012-09-25 10:19       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 10:39         ` Sascha Hauer
2012-09-23 11:00   ` Sascha Hauer [this message]
2012-09-23 13:22     ` [PATCH 1/5] video: add atmel lcdc frambuffer support Jean-Christophe PLAGNIOL-VILLARD
  -- strict thread matches above, loose matches on Subject: below --
2012-09-21 12:51 [PATCH 0/5] at91 framebuffer support Jean-Christophe PLAGNIOL-VILLARD
2012-09-21 12:55 ` [PATCH 1/5] video: add atmel lcdc frambuffer support Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 10:34   ` Sascha Hauer
2012-09-22 16:11     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-22 17:44     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120923110000.GJ1322@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox