Re: [PATCH 5/5] at91sam9m10g45ek: add lcdc support

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 10:09 Tue 25 Sep     , Sascha Hauer wrote:
> On Sat, Sep 22, 2012 at 08:26:48PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > ---
> >  .../arm/boards/at91sam9m10g45ek/env/bin/boot_board |    7 +++++
> >  arch/arm/boards/at91sam9m10g45ek/env/splash.png    |  Bin 0 -> 22747 bytes
> >  arch/arm/boards/at91sam9m10g45ek/init.c            |   33 ++++++++++++++++++++
> >  arch/arm/configs/at91sam9m10g45ek_defconfig        |   11 +++++--
> >  4 files changed, 48 insertions(+), 3 deletions(-)
> >  create mode 100644 arch/arm/boards/at91sam9m10g45ek/env/splash.png
> > 
> > diff --git a/arch/arm/boards/at91sam9m10g45ek/env/bin/boot_board b/arch/arm/boards/at91sam9m10g45ek/env/bin/boot_board
> > index 3d7426f..eeb7a76 100644
> > --- a/arch/arm/boards/at91sam9m10g45ek/env/bin/boot_board
> > +++ b/arch/arm/boards/at91sam9m10g45ek/env/bin/boot_board
> > @@ -5,6 +5,13 @@ export PATH
> >  
> >  . /env/config
> >  
> > +splash=/env/splash.png
> > +
> > +if [ -f ${splash} ]; then
> > +	splash ${splash}
> > +	fb0.enable=1
> > +fi
> > +
> >  menu -r -m boot
> >  menu -a -m boot -d "\e[1;36mWelcome on Barebox Boot Sequence\e[0m"
> >  menu -e -a -m boot -c 'menu_boot'			-d "boot (default)             "
> > diff --git a/arch/arm/boards/at91sam9m10g45ek/env/splash.png b/arch/arm/boards/at91sam9m10g45ek/env/splash.png
> 
> I understand your desire to show a logo on the screen, but we really
> need a storage outside the main repository for this. I'm perfectly fine
> with showing full HD 3d pictures on the screen if your hardware can do
> so, but we should not put this into the repository.
> 
> We should solve this right now, then we are free to add huge logos, add
> different logo for each board, update logos for christmas, summer,
> Helloween...
> 
> How about adding some wget mechanism which:
> 
> - Only downloads the logos if allowed in the config
> - Does not download logos if a logo directory already exists
> 
> I'm sure we could create some storage here.
I nack the wget not the idea

how about a git submodule

as I must have the offline build support

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox