Re: [PATCH 0/1 v7] net: introduce phylib

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 13:31 Wed 26 Sep     , Sascha Hauer wrote:
> On Wed, Sep 26, 2012 at 01:20:07PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 13:02 Wed 26 Sep     , Sascha Hauer wrote:
> > > 
> > > barebox@Freescale i.MX51 PDK:/ dhcp 
> > > T transmission timeout
> > > T T transmission timeout
> > > T T transmission timeout
> > > T T transmission timeout
> > > T T transmission timeout
> > > 
> > > Plugging in a cable does not help, since the link status is only
> > > evaluated once during eth_open. If then a cable is plugged, adjust_link
> > > is never called, so the driver never adjusts to the actual link.
> > no this should not happend with the current code
> 
> Appearantly the code does not know what should and what should not
> happen.
> 
> > eth_send set the device as not active if eth_open failled of phy is not up
> 
> eth_send doesn't, but eth_rx does.
no it really in eth_send I found the bug I did a mistake in v7 I drop a check
in eth_send that report the phy down

I send the fix

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox