From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 11.mo5.mail-out.ovh.net ([46.105.47.167] helo=mo5.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TGpxi-0005mi-73 for barebox@lists.infradead.org; Wed, 26 Sep 2012 11:39:31 +0000 Received: from mail404.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo5.mail-out.ovh.net (Postfix) with SMTP id 20FD9FFBDEC for ; Wed, 26 Sep 2012 13:45:29 +0200 (CEST) Date: Wed, 26 Sep 2012 13:36:58 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120926113658.GP26553@game.jcrosoft.org> References: <20120924093122.GD26553@game.jcrosoft.org> <20120926110244.GH24458@pengutronix.de> <20120926112007.GO26553@game.jcrosoft.org> <20120926113116.GN1322@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120926113116.GN1322@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 0/1 v7] net: introduce phylib To: Sascha Hauer Cc: barebox@lists.infradead.org On 13:31 Wed 26 Sep , Sascha Hauer wrote: > On Wed, Sep 26, 2012 at 01:20:07PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 13:02 Wed 26 Sep , Sascha Hauer wrote: > > > > > > barebox@Freescale i.MX51 PDK:/ dhcp > > > T transmission timeout > > > T T transmission timeout > > > T T transmission timeout > > > T T transmission timeout > > > T T transmission timeout > > > > > > Plugging in a cable does not help, since the link status is only > > > evaluated once during eth_open. If then a cable is plugged, adjust_link > > > is never called, so the driver never adjusts to the actual link. > > no this should not happend with the current code > > Appearantly the code does not know what should and what should not > happen. > > > eth_send set the device as not active if eth_open failled of phy is not up > > eth_send doesn't, but eth_rx does. no it really in eth_send I found the bug I did a mistake in v7 I drop a check in eth_send that report the phy down I send the fix Best Regards, J. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox