Re: [PATCH 02/23] clk clkdev: Add clkdev matching based on physbase

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 13:04 Mon 24 Sep     , Sascha Hauer wrote:
> Most clock/device associations can be done based on the physical
> base address of the corresponding device. So instead of depending
> on string matching add an optional possibility to associate a clock
> lookups with physical addresses. This also has the advantage that
> the lookups for devicetree based devices can be identical to the
> platform based devices.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/clk/clkdev.c   |   47 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/clkdev.h |    3 +++
>  2 files changed, 50 insertions(+)
> 
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 717fea5..40bc006 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -62,6 +62,32 @@ static struct clk *clk_find(const char *dev_id, const char *con_id)
>  	return clk;
>  }
>  
> +static struct clk *clk_find_physbase(struct device_d *dev, const char *con_id)
> +{
> +	struct clk_lookup *p;
> +	unsigned long start;
> +
> +	if (!dev || !dev->resource)
> +		return ERR_PTR(-ENOSYS);
this is broken

clk_get_sys(NULL, "toto") is a valid call

Best Regars,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox