From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 14.mo5.mail-out.ovh.net ([188.165.51.82] helo=mo5.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TGx1Q-0002uk-G2 for barebox@lists.infradead.org; Wed, 26 Sep 2012 19:11:49 +0000 Received: from mail404.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo5.mail-out.ovh.net (Postfix) with SMTP id E2B4EFFB928 for ; Wed, 26 Sep 2012 21:17:49 +0200 (CEST) Date: Wed, 26 Sep 2012 21:09:18 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120926190918.GB26553@game.jcrosoft.org> References: <1348484692-24993-1-git-send-email-s.hauer@pengutronix.de> <1348484692-24993-3-git-send-email-s.hauer@pengutronix.de> <20120926160239.GV26553@game.jcrosoft.org> <20120926172516.GR1322@pengutronix.de> <20120926185346.GZ26553@game.jcrosoft.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120926185346.GZ26553@game.jcrosoft.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 02/23] clk clkdev: Add clkdev matching based on physbase To: Sascha Hauer Cc: barebox@lists.infradead.org On 20:53 Wed 26 Sep , Jean-Christophe PLAGNIOL-VILLARD wrote: > On 19:25 Wed 26 Sep , Sascha Hauer wrote: > > On Wed, Sep 26, 2012 at 06:02:39PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 13:04 Mon 24 Sep , Sascha Hauer wrote: > > > > Most clock/device associations can be done based on the physical > > > > base address of the corresponding device. So instead of depending > > > > on string matching add an optional possibility to associate a clock > > > > lookups with physical addresses. This also has the advantage that > > > > the lookups for devicetree based devices can be identical to the > > > > platform based devices. > > > > > > > > Signed-off-by: Sascha Hauer > > > > --- > > > > drivers/clk/clkdev.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > > > > include/linux/clkdev.h | 3 +++ > > > > 2 files changed, 50 insertions(+) > > > > > > > > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c > > > > index 717fea5..40bc006 100644 > > > > --- a/drivers/clk/clkdev.c > > > > +++ b/drivers/clk/clkdev.c > > > > @@ -62,6 +62,32 @@ static struct clk *clk_find(const char *dev_id, const char *con_id) > > > > return clk; > > > > } > > > > > > > > +static struct clk *clk_find_physbase(struct device_d *dev, const char *con_id) > > > > +{ > > > > + struct clk_lookup *p; > > > > + unsigned long start; > > > > + > > > > + if (!dev || !dev->resource) > > > > + return ERR_PTR(-ENOSYS); > > > this is broken > > > > > > clk_get_sys(NULL, "toto") is a valid call > > > > clk_get_sys never calls clk_find_physbase. clk_get(NULL, "toto") will > > call clk_find_physbase in which case clk_find_physbase returns -ENOSYS > > and clk_get falls back to clk_get_sys just as it did before. > it's clk_get (NULL, "toto) > > that fail which is basilcally used on at91 > > and a device without resources cannot get it's clock ignore this Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox