mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: barebox@lists.infradead.org, brian@crystalfontz.com
Subject: Re: [PATCH] arm: cfa10036: Add proper resource length
Date: Fri, 28 Sep 2012 16:32:07 +0200	[thread overview]
Message-ID: <20120928143207.GF1322@pengutronix.de> (raw)
In-Reply-To: <1348840692-1913-1-git-send-email-maxime.ripard@free-electrons.com>

On Fri, Sep 28, 2012 at 03:58:12PM +0200, Maxime Ripard wrote:
> The cfa10036 board file were missing the length parameter when adding
> devices. This made barebox crash early in the boot, in the mxs-mci
> driver.
> 
> Provide the resources lengths in a consistent format.

Applied, thanks

Sascha

> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  arch/arm/boards/crystalfontz-cfa10036/cfa10036.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
> index e454afd..fcb7057 100644
> --- a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
> +++ b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
> @@ -23,6 +23,7 @@
>  #include <init.h>
>  #include <mci.h>
>  #include <io.h>
> +#include <sizes.h>
>  
>  #include <mach/clock.h>
>  #include <mach/imx-regs.h>
> @@ -89,7 +90,7 @@ static int cfa10036_devices_init(void)
>  	armlinux_set_bootparams((void *)IMX_MEMORY_BASE + 0x100);
>  	armlinux_set_architecture(MACH_TYPE_CFA10036);
>  
> -	add_generic_device("mxs_mci", 0, NULL, IMX_SSP0_BASE, 0,
> +	add_generic_device("mxs_mci", 0, NULL, IMX_SSP0_BASE, SZ_8K,
>  			   IORESOURCE_MEM, &mci_pdata);
>  
>  	return 0;
> @@ -98,7 +99,7 @@ device_initcall(cfa10036_devices_init);
>  
>  static int cfa10036_console_init(void)
>  {
> -	add_generic_device("stm_serial", 0, NULL, IMX_DBGUART_BASE, 8192,
> +	add_generic_device("stm_serial", 0, NULL, IMX_DBGUART_BASE, SZ_8K,
>  			   IORESOURCE_MEM, NULL);
>  
>  	return 0;
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-28 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 13:58 Maxime Ripard
2012-09-28 14:32 ` Sascha Hauer [this message]
2012-09-28 14:39   ` Maxime Ripard
2012-09-28 17:37     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928143207.GF1322@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=brian@crystalfontz.com \
    --cc=maxime.ripard@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox