mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, vj <vicencb@gmail.com>
Subject: Re: [PATCH 6/9] omap4: add usb boot support
Date: Sun, 30 Sep 2012 16:02:25 +0200	[thread overview]
Message-ID: <20120930140225.GR26553@game.jcrosoft.org> (raw)
In-Reply-To: <CAA4bVAG-yzYGNb4mNGTT=hcz1EwAcgDZyKVWnZ-aM8AVaN3wmg@mail.gmail.com>

On 16:14 Sun 30 Sep     , Antony Pavlov wrote:
> On 30 September 2012 06:50, vj <vicencb@gmail.com> wrote:
> > ---
> >  arch/arm/cpu/cpu.c                              |   1 +
> >  arch/arm/mach-omap/Kconfig                      |   7 +
> >  arch/arm/mach-omap/Makefile                     |   1 +
> >  arch/arm/mach-omap/include/mach/omap4_rom_usb.h | 142 ++++++++
> >  arch/arm/mach-omap/omap4_generic.c              |  13 +
> >  arch/arm/mach-omap/omap4_rom_usb.c              | 186 +++++++++++
> >  scripts/.gitignore                              |   1 +
> >  scripts/Makefile                                |   4 +
> >  scripts/omap4_usbboot.c                         | 416 ++++++++++++++++++++++++
> >  scripts/usb.h                                   |  61 ++++
> >  scripts/usb_linux.c                             | 397 ++++++++++++++++++++++
> >  11 files changed, 1229 insertions(+)
> >  create mode 100644 arch/arm/mach-omap/include/mach/omap4_rom_usb.h
> >  create mode 100644 arch/arm/mach-omap/omap4_rom_usb.c
> >  create mode 100644 scripts/omap4_usbboot.c
> >  create mode 100644 scripts/usb.h
> >  create mode 100644 scripts/usb_linux.c
> >
> > diff --git a/arch/arm/cpu/cpu.c b/arch/arm/cpu/cpu.c
> > index 71ef8c0..05343de 100644
> > --- a/arch/arm/cpu/cpu.c
> > +++ b/arch/arm/cpu/cpu.c
> > @@ -89,6 +89,7 @@ void arch_shutdown(void)
> >                 : "r0", "r1", "r2", "r3", "r6", "r10", "r12", "lr", "cc", "memory"
> >         );
> >  #endif
> > +       __asm__ __volatile__ ("cpsid i\n");
???

why do you add this?

we never enable the interrupt

and this is generic not omap4 must be in a seperate patch


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-30 14:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-30  2:50 [PATCH 0/9] archosg9: add support for tablet, second round vj
2012-09-30  2:50 ` [PATCH 1/9] ARM: set rev instead of returning it vj
2012-09-30  2:50 ` [PATCH 2/9] mmc_omap: improve error message vj
2012-09-30  2:50 ` [PATCH 3/9] omap4: add/rename definitions to match datasheet vj
2012-09-30  2:50 ` [PATCH 4/9] twl6030: add debug info vj
2012-09-30 13:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 13:46   ` Sascha Hauer
2012-09-30  2:50 ` [PATCH 5/9] add gitignore file vj
2012-09-30  2:50 ` [PATCH 6/9] omap4: add usb boot support vj
2012-09-30 12:14   ` Antony Pavlov
2012-09-30 14:02     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-30 15:02       ` vj
2012-09-30 15:29         ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 16:00           ` vj
2012-10-01 12:48             ` Sascha Hauer
2012-09-30 14:07   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 15:23     ` vj
2012-09-30 15:30     ` vj
     [not found]     ` <CAAMcf8B0Qif3zVfw44zx5G813fYrMQTfUKi86Kr+JuFm=yf5rQ@mail.gmail.com>
2012-09-30 15:32       ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 13:51   ` Sascha Hauer
2012-09-30  2:50 ` [PATCH 7/9] omap4: add serial communications over usb boot vj
2012-09-30  2:50 ` [PATCH 8/9] omap4: add filesystem support " vj
2012-09-30 13:53   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30  2:50 ` [PATCH 9/9] Add support for Archos G9 tablet vj
2012-09-30 14:00   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 15:02   ` Antony Pavlov
2012-10-02 17:06 ` [PATCH 0/9] archosg9: add support for tablet, second round Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120930140225.GR26553@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox