From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] gpio: provide generic gpio header
Date: Fri, 5 Oct 2012 14:21:25 +0200 [thread overview]
Message-ID: <20121005122125.GQ1322@pengutronix.de> (raw)
In-Reply-To: <1349435923-29233-2-git-send-email-plagnioj@jcrosoft.com>
On Fri, Oct 05, 2012 at 01:18:41PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> include/asm-generic/gpio.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 include/asm-generic/gpio.h
>
> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> new file mode 100644
> index 0000000..1997888
> --- /dev/null
> +++ b/include/asm-generic/gpio.h
> @@ -0,0 +1,10 @@
> +#ifndef __ASM_GENERIC_GPIO_H
> +#define __ASM_GENERIC_GPIO_H
> +
> +void gpio_set_value(unsigned gpio, int value);
> +int gpio_get_value(unsigned gpio);
> +int gpio_direction_output(unsigned gpio, int value);
> +int gpio_direction_input(unsigned gpio);
> +
> +#endif /* __ASM_GENERIC_GPIO_H */
> +
No newline at end of file please.
Since you are adding a generic file, which is good, could you also
cleanup the potential users?
./arch/arm/mach-at91/include/mach/gpio.h
./arch/arm/mach-mxs/include/mach/gpio.h
./arch/arm/mach-imx/include/mach/gpio.h
./arch/arm/mach-pxa/include/plat/gpio.h
./arch/arm/mach-pxa/include/mach/gpio.h
./arch/arm/mach-samsung/include/mach/gpio.h
./arch/arm/mach-ep93xx/include/mach/gpio.h
./arch/arm/mach-omap/include/mach/gpio.h
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-05 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 11:04 [PATCH 0/4] add gpio primcell pl061 support Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 11:18 ` [PATCH 1/4] gpiolib: select GENERIC_GPIO Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 11:18 ` [PATCH 2/4] gpio: provide generic gpio header Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 12:21 ` Sascha Hauer [this message]
2012-10-05 11:18 ` [PATCH 3/4] gpio: add ARM Primcell pl061 support Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 12:29 ` Sascha Hauer
2012-10-05 11:18 ` [PATCH 4/4] versatilepb: add gpio support Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 13:20 [PATCH 0/4 v2] add gpio primcell pl061 support Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 13:25 ` [PATCH 1/4] gpiolib: select GENERIC_GPIO Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 13:25 ` [PATCH 2/4] gpio: provide generic gpio header Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005122125.GQ1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox