mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Gregory Hermant <gregory.hermant@calao-systems.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Add support for the Calao-systems HABA-KNX controllers
Date: Fri, 5 Oct 2012 15:41:31 +0200	[thread overview]
Message-ID: <20121005134131.GU1322@pengutronix.de> (raw)
In-Reply-To: <1349422624-5278-1-git-send-email-gregory.hermant@calao-systems.com>

On Fri, Oct 05, 2012 at 09:37:03AM +0200, Gregory Hermant wrote:
> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

>  create mode 100644 arch/arm/boards/haba-knx/Makefile
>  create mode 100644 arch/arm/boards/haba-knx/config.h
>  create mode 100644 arch/arm/boards/haba-knx/env/boot.d/10
>  create mode 100644 arch/arm/boards/haba-knx/env/boot.d/11
>  create mode 100644 arch/arm/boards/haba-knx/env/boot.d/12
>  create mode 100644 arch/arm/boards/haba-knx/env/boot.d/13

Please drop the links for now until the boot sequence patches are
reworked.

> +
> +# MAC address if needed
> +#ethaddr=xx:xx:xx:xx:xx:xx
> +ethaddr=6a:63:73:00:00:34

No hardcoded MAC addresses in the environment please.

> +#include <spi/flash.h>
> +
> +static void haba_knx_set_board_type(void)
> +{
> +	if (machine_is_haba_knx_lite())
> +		armlinux_set_architecture(MACH_TYPE_HABA_KNX_LITE);
> +	else
> +		armlinux_set_architecture(MACH_TYPE_HABA_KNX_EXPLORER);

Can the board type somehow be autodetected? That would be great.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-10-05 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05  7:37 Gregory Hermant
2012-10-05  7:37 ` [PATCH 2/2] mach-types file updated Gregory Hermant
2012-10-05 13:41 ` Sascha Hauer [this message]
2012-10-05 14:18   ` [PATCH 1/2] Add support for the Calao-systems HABA-KNX controllers Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121005134131.GU1322@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=gregory.hermant@calao-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox