From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] davinci_emac: fix comment for the _send function
Date: Fri, 5 Oct 2012 18:52:21 +0200 [thread overview]
Message-ID: <20121005165221.GY1322@pengutronix.de> (raw)
In-Reply-To: <1349440069-23987-1-git-send-email-antonynpavlov@gmail.com>
On Fri, Oct 05, 2012 at 04:27:49PM +0400, Antony Pavlov wrote:
> The _send function should not return the length
> of the transmitted packet.
>
> See also
>
> commit 76c4c9e48ffbe35490e1f7d3abcedc04934ac302
> Author: Jan Luebbe <jlu@pengutronix.de>
> Date: Fri Sep 28 18:17:44 2012 +0200
>
> davinci_emac: return 0 on successful transmit
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> drivers/net/davinci_emac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 5bd5f30..989e119 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -387,8 +387,8 @@ static void davinci_emac_halt(struct eth_device *edev)
> }
>
> /*
> - * This function sends a single packet on the network and returns
> - * positive number (number of bytes transmitted) or negative for error
> + * This function sends a single packet on the network
> + * and returns 0 on successful transmit or negative for error
> */
> static int davinci_emac_send(struct eth_device *edev, void *packet, int length)
> {
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-10-05 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 12:27 Antony Pavlov
2012-10-05 16:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005165221.GY1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox