[PATCH] davinci_emac: fix comment for the _send function

[PATCH] davinci_emac: fix comment for the _send function

[Antony Pavlov]

The _send function should not return the length
of the transmitted packet.

See also

commit 76c4c9e48ffbe35490e1f7d3abcedc04934ac302
Author: Jan Luebbe <jlu@pengutronix.de>
Date:   Fri Sep 28 18:17:44 2012 +0200

    davinci_emac: return 0 on successful transmit

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/net/davinci_emac.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 5bd5f30..989e119 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -387,8 +387,8 @@ static void davinci_emac_halt(struct eth_device *edev)
 }
 
 /*
- * This function sends a single packet on the network and returns
- * positive number (number of bytes transmitted) or negative for error
+ * This function sends a single packet on the network
+ * and returns 0 on successful transmit or negative for error
  */
 static int davinci_emac_send(struct eth_device *edev, void *packet, int length)
 {
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] davinci_emac: fix comment for the _send function

[Sascha Hauer]

On Fri, Oct 05, 2012 at 04:27:49PM +0400, Antony Pavlov wrote:
> The _send function should not return the length
> of the transmitted packet.
> 
> See also
> 
> commit 76c4c9e48ffbe35490e1f7d3abcedc04934ac302
> Author: Jan Luebbe <jlu@pengutronix.de>
> Date:   Fri Sep 28 18:17:44 2012 +0200
> 
>     davinci_emac: return 0 on successful transmit
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

> ---
>  drivers/net/davinci_emac.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 5bd5f30..989e119 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -387,8 +387,8 @@ static void davinci_emac_halt(struct eth_device *edev)
>  }
>  
>  /*
> - * This function sends a single packet on the network and returns
> - * positive number (number of bytes transmitted) or negative for error
> + * This function sends a single packet on the network
> + * and returns 0 on successful transmit or negative for error
>   */
>  static int davinci_emac_send(struct eth_device *edev, void *packet, int length)
>  {
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox