From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: vj <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 02/11] twl6030: add debug info
Date: Sat, 6 Oct 2012 11:30:52 +0200 [thread overview]
Message-ID: <20121006093052.GU26553@game.jcrosoft.org> (raw)
In-Reply-To: <1349476393-25520-3-git-send-email-vicencb@gmail.com>
On 00:33 Sat 06 Oct , vj wrote:
>
> Signed-off-by: vj <vicencb@gmail.com>
> ---
> drivers/mfd/twl6030.c | 20 ++++++++++++++++++++
> include/mfd/twl6030.h | 8 ++++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/drivers/mfd/twl6030.c b/drivers/mfd/twl6030.c
> index 01728fd..87ee232 100644
> --- a/drivers/mfd/twl6030.c
> +++ b/drivers/mfd/twl6030.c
> @@ -39,6 +39,26 @@ static int twl_probe(struct device_d *dev)
>
> devfs_create(&(twl_dev->core.cdev));
>
> + if (IS_ENABLED(DEBUG)) {
CONFIG_DEBUG instead?
> + u8 i, jtag_rev, eprom_rev;
> + int r;
> + u64 dieid;
add one empty line
> + r = twl6030_reg_read(twl_dev, TWL6030_JTAG_JTAGVERNUM,
> + &jtag_rev);
> + r |= twl6030_reg_read(twl_dev, TWL6030_JTAG_EPROM_REV,
> + &eprom_rev);
> + for (i = 0; i < 8; i++)
> + r |= twl6030_reg_read(twl_dev, TWL6030_DIEID_0+i,
> + ((u8 *)(&dieid))+i);
> + if (r)
> + dev_dbg(dev, "TWL6030 Error reading ID\n");
> + else
> + dev_dbg(dev, "TWL6030 JTAG REV: 0x%02X, "
> + "EPROM REV: 0x%02X, "
> + "DIE ID: 0x%016llX\n",
> + (unsigned)jtag_rev, (unsigned)eprom_rev, dieid);
> + }
> +
> return 0;
> }
>
> diff --git a/include/mfd/twl6030.h b/include/mfd/twl6030.h
> index f1278d4..bb4f773 100644
> --- a/include/mfd/twl6030.h
> +++ b/include/mfd/twl6030.h
> @@ -371,6 +371,14 @@ enum twl6030_reg {
> /* JTAG */
> TWL6030_JTAG_JTAGVERNUM = 0x0287,
> TWL6030_JTAG_EPROM_REV = 0x02DF,
> + TWL6030_DIEID_0 = 0x02C0,
> + TWL6030_DIEID_1 = 0x02C1,
> + TWL6030_DIEID_2 = 0x02C2,
> + TWL6030_DIEID_3 = 0x02C3,
> + TWL6030_DIEID_4 = 0x02C4,
> + TWL6030_DIEID_5 = 0x02C5,
> + TWL6030_DIEID_6 = 0x02C6,
> + TWL6030_DIEID_7 = 0x02C7,
> /* GPADC Trimming */
> TWL6030_GPADC_TRIM1 = 0x02CD,
> TWL6030_GPADC_TRIM2 = 0x02CE,
> --
> 1.7.12.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-06 9:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 22:33 [PATCH 00/11] archosg9: add support for tablet, third round vj
2012-10-05 22:33 ` [PATCH 01/11] regression: reset can not return vj
2012-10-07 9:42 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 02/11] twl6030: add debug info vj
2012-10-06 9:30 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-05 22:33 ` [PATCH 03/11] omap4: add/rename definitions to match datasheet vj
2012-10-05 22:33 ` [PATCH 04/11] ARM: ensure irqs are disabled vj
2012-10-07 9:46 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 05/11] omap: revert gpiolib vj
2012-10-07 10:11 ` Sascha Hauer
2012-10-09 6:30 ` Teresa Gamez
2012-10-09 6:54 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 06/11] omap4: add support for booting an omap4 from usb vj
2012-10-07 10:23 ` Sascha Hauer
2012-10-05 22:33 ` [PATCH 07/11] omap4: add serial communications over usb boot vj
2012-10-05 22:33 ` [PATCH 08/11] omap4: add filesystem support " vj
2012-10-05 22:33 ` [PATCH 09/11] omap4: add support for loading second stage from usb vj
2012-10-05 22:33 ` [PATCH 10/11] mach-types: add ID for Archos G9 tablet vj
2012-10-07 10:30 ` Sascha Hauer
2012-10-07 12:07 ` vj
2012-10-07 12:16 ` Sascha Hauer
2012-10-07 12:26 ` vj
2012-10-07 13:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 13:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-05 22:33 ` [PATCH 11/11] Add support " vj
2012-10-07 10:34 ` [PATCH 00/11] archosg9: add support for tablet, third round Sascha Hauer
2012-10-07 12:12 ` vj
2012-10-07 12:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121006093052.GU26553@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox