From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: Add CLPS711X architecture
Date: Sun, 7 Oct 2012 13:55:15 +0200 [thread overview]
Message-ID: <20121007115515.GH1322@pengutronix.de> (raw)
In-Reply-To: <20121007145701.75a20196.shc_work@mail.ru>
On Sun, Oct 07, 2012 at 02:57:01PM +0400, Alexander Shiyan wrote:
> On Sun, 7 Oct 2012 12:45:50 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> ...
> > And in the driver:
> >
> > #define SYSCON 0x100
> >
> > ...
> > writel(0xdeadbeef, base + SYSCON);
> > ...
> You a right, but SYSCON is used not only for UARTs. This register also
> used for setup timers, keypad, lcd, spi etc... Just look on bit definitions.
> Same I can say about other resisters.
Oh my gosh, that indeed looks strange... Normally register regions are
reserved for separate units, on this SoC it seems more that bit
positions inside registers are reserved for separate units ;)
> In this case we have some redundancy definitions. I will think about other way.
Try and have a look if you could clean this up a bit, but it might be
that you already found the best solution.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-07 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 12:36 [PATCH 1/3] ARM: Fix Kconfig link for Cirrus Logic EP9312 CPU Alexander Shiyan
2012-10-04 12:37 ` [PATCH 2/3] Add more generated files to .gitignore Alexander Shiyan
2012-10-04 12:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-04 13:04 ` Re[2]: " Alexander Shiyan
2012-10-04 13:20 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-04 12:37 ` [PATCH 3/3] ARM: Add CLPS711X architecture Alexander Shiyan
2012-10-04 12:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-04 15:14 ` Alexander Shiyan
2012-10-04 17:08 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-04 17:19 ` Alexander Shiyan
2012-10-05 12:12 ` Sascha Hauer
2012-10-07 10:03 ` Alexander Shiyan
2012-10-07 10:45 ` Sascha Hauer
2012-10-07 10:57 ` Alexander Shiyan
2012-10-07 11:55 ` Sascha Hauer [this message]
2012-10-05 11:50 ` [PATCH 1/3] ARM: Fix Kconfig link for Cirrus Logic EP9312 CPU Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121007115515.GH1322@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox