From: Johannes Stezenbach <js@sig21.net>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] designware: add clock support
Date: Mon, 8 Oct 2012 11:03:13 +0200 [thread overview]
Message-ID: <20121008090313.GA5498@sig21.net> (raw)
In-Reply-To: <1349614983-12495-1-git-send-email-plagnioj@jcrosoft.com>
On Sun, Oct 07, 2012 at 03:03:03PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> allow the driver to request it's clock and enable it
...
> + clk = clk_get(dev, NULL);
> + if (IS_ERR(clk)) {
> + ret = PTR_ERR(clk);
> + dev_err(dev, "no clk ret = %d\n", ret);
> + return ret;
> + }
Just a minor nit: s/allow/require/. Users of the driver may
now have to define a dummy clock. Since the actual clock freqeuency
is not used by the driver you could also make it optional?
And while at it, it's "its", not "it's". :-)
Johannes
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-08 9:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 13:03 Jean-Christophe PLAGNIOL-VILLARD
2012-10-08 9:03 ` Johannes Stezenbach [this message]
2012-10-08 9:27 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-08 10:00 ` Johannes Stezenbach
2012-10-10 9:03 ` Sascha Hauer
2012-10-10 9:06 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008090313.GA5498@sig21.net \
--to=js@sig21.net \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox