From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TLJmH-0007c4-Nk for barebox@lists.infradead.org; Mon, 08 Oct 2012 20:18:14 +0000 Date: Mon, 8 Oct 2012 22:18:11 +0200 From: Sascha Hauer Message-ID: <20121008201811.GR1322@pengutronix.de> References: <1349647287-28224-1-git-send-email-vicencb@gmail.com> <1349647287-28224-7-git-send-email-vicencb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1349647287-28224-7-git-send-email-vicencb@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 06/13] bootm: close open files To: Vicente Cc: barebox@lists.infradead.org On Mon, Oct 08, 2012 at 12:01:20AM +0200, Vicente wrote: > > Signed-off-by: Vicente > --- > arch/arm/lib/bootm.c | 4 +++- > commands/bootm.c | 6 +++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c > index c5b76ea..288c0b2 100644 > --- a/arch/arm/lib/bootm.c > +++ b/arch/arm/lib/bootm.c > @@ -269,8 +269,9 @@ static int do_bootz_linux(struct image_data *data) > > ret = do_bootz_linux_fdt(fd, data); > if (ret && ret != -ENXIO) > - return ret; > + goto err_out; > > + close(fd); > return __do_bootm_linux(data, swap); ret = __do_bootm_linux and fall through? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox