From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 2.mo2.mail-out.ovh.net ([188.165.53.149] helo=mo2.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TLsnR-0003xk-8u for barebox@lists.infradead.org; Wed, 10 Oct 2012 09:41:46 +0000 Received: from mail611.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo2.mail-out.ovh.net (Postfix) with SMTP id 63344DC1ADC for ; Wed, 10 Oct 2012 11:48:09 +0200 (CEST) Date: Wed, 10 Oct 2012 11:39:21 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20121010093921.GG26553@game.jcrosoft.org> References: <1349694156-30554-1-git-send-email-s.hauer@pengutronix.de> <20121008121527.GY26553@game.jcrosoft.org> <20121010084637.GR27665@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20121010084637.GR27665@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM at91sam9260ek: remove unused reset entry To: Sascha Hauer Cc: barebox@lists.infradead.org On 10:46 Wed 10 Oct , Sascha Hauer wrote: > On Mon, Oct 08, 2012 at 04:24:18PM +0400, Antony Pavlov wrote: > > On 8 October 2012 16:15, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > > > On 13:02 Mon 08 Oct , Sascha Hauer wrote: > > >> The at91sam9260ek has a custom reset function which does the same thing > > >> as the default function. Also it does not define MACH_HAS_LOWLEVEL_INIT > > >> as it should do. Remove the function. > > >> > > >> Signed-off-by: Sascha Hauer > > >> --- > > > Acked-by: Jean-Christophe PLAGNIOL-VILLARD > > > > > > btw we should rename the command reset reboot because it start to be confusing > > > > IMHO it is a very good idea! > > I would rather use a different name for the reset functions which are in > the startup code. In the end the reset command just resets the board. > 'reboot' sounds like something is being shutdown before restarting a > board. > > Changing a command is quite painful since all environment scripts will > be broken. I don't think reset is used in the environment, but the > API change to the mount command always nags me when using a new barebox > which has an older environment in flash. I think we really have to be > more careful when changing commands. reset means reset the screen in linux and I check nearly no one use reset in the env execpt sam9g45 and defaultenv2 when I ask to do not update the var to pass the arch number on arm you give the invert comment env evolve and we do not want to loose tis freedom Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox