From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM OMAP: Use wrapper in board files
Date: Thu, 11 Oct 2012 14:44:11 +0200 [thread overview]
Message-ID: <20121011124411.GB13639@game.jcrosoft.org> (raw)
In-Reply-To: <1349940335-20960-2-git-send-email-t.gamez@phytec.de>
On 09:25 Thu 11 Oct , Teresa Gámez wrote:
> Use the omap wrappers in board files instead of add_generic_device().
> Compile tested every affected board. Tested on pcm049.
>
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
> arch/arm/boards/beagle/board.c | 17 +++++------------
> arch/arm/boards/omap343xdsp/board.c | 12 ++++--------
> arch/arm/boards/omap3evm/board.c | 18 +++++-------------
> arch/arm/boards/panda/board.c | 19 +++++--------------
> arch/arm/boards/pcm049/board.c | 21 +++++++--------------
> arch/arm/boards/phycard-a-l1/pca-a-l1.c | 20 +++++---------------
> arch/arm/boards/phycard-a-xl2/pca-a-xl2.c | 21 +++++++--------------
> 7 files changed, 38 insertions(+), 90 deletions(-)
>
> diff --git a/arch/arm/boards/beagle/board.c b/arch/arm/boards/beagle/board.c
> index 19bf740..bab11c8 100644
> --- a/arch/arm/boards/beagle/board.c
> +++ b/arch/arm/boards/beagle/board.c
> @@ -62,6 +62,7 @@
> #include <mach/sys_info.h>
> #include <mach/syslib.h>
> #include <mach/control.h>
> +#include <mach/devices.h>
> #include <mach/omap3-mux.h>
> #include <mach/gpmc.h>
> #include <mach/gpmc_nand.h>
> @@ -235,11 +236,6 @@ pure_initcall(beagle_board_init);
>
> #ifdef CONFIG_DRIVER_SERIAL_NS16550
>
> -static struct NS16550_plat serial_plat = {
> - .clock = 48000000, /* 48MHz (APLL96/2) */
> - .shift = 2,
> -};
> -
> /**
> * @brief UART serial port initialization - remember to enable COM clocks in
> * arch
> @@ -249,8 +245,7 @@ static struct NS16550_plat serial_plat = {
> static int beagle_console_init(void)
> {
> /* Register the serial port */
> - add_ns16550_device(DEVICE_ID_DYNAMIC, OMAP_UART3_BASE, 1024, IORESOURCE_MEM_8BIT,
> - &serial_plat);
> + omap_add_ns16550(OMAP_UART3_BASE);
do not even provide the base at board level
>
> return 0;
> }
> @@ -287,7 +282,7 @@ static struct gpmc_nand_platform_data nand_plat = {
>
> static int beagle_mem_init(void)
> {
> - arm_add_mem_device("ram0", 0x80000000, 128 * 1024 * 1024);
> + omap_add_ram0(SZ_128M);
>
> return 0;
> }
> @@ -296,8 +291,7 @@ mem_initcall(beagle_mem_init);
> static int beagle_devices_init(void)
> {
> i2c_register_board_info(0, i2c_devices, ARRAY_SIZE(i2c_devices));
> - add_generic_device("i2c-omap", DEVICE_ID_DYNAMIC, NULL, OMAP_I2C1_BASE, SZ_4K,
> - IORESOURCE_MEM, NULL);
> + omap_add_i2c(OMAP_I2C1_BASE, NULL);
ditoo and etc..
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-11 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 7:25 [PATCH 1/2] ARM OMAP: Create device file Teresa Gámez
2012-10-11 7:25 ` [PATCH 2/2] ARM OMAP: Use wrapper in board files Teresa Gámez
2012-10-11 12:44 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-12 7:58 ` [PATCH 1/2] ARM OMAP: Create device file Sascha Hauer
2012-10-12 9:30 ` Teresa Gamez
2012-10-13 12:10 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011124411.GB13639@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox