mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM OMAP: Create device file
Date: Fri, 12 Oct 2012 09:58:35 +0200	[thread overview]
Message-ID: <20121012075835.GG27665@pengutronix.de> (raw)
In-Reply-To: <1349940335-20960-1-git-send-email-t.gamez@phytec.de>

Hi Teresa,

On Thu, Oct 11, 2012 at 09:25:34AM +0200, Teresa Gámez wrote:
> Created wrapper to add omap devices.
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
> +
> +struct device_d *omap_add_mmc(resource_size_t base, void *pdata)
> +{
> +	return omap_add_device("omap-hsmmc", base, SZ_4K, pdata);
> +}

Nice work. As Jean Christophe already mentioned, it would be nice to
skip the base address. That would mean to have a omap_add_mmc() function
like above in an omap generic place and then:

static inline struct device_d omap<x>_add_mmc<y>(void *pdata)
{
	omap_add_mmc(OMAPx_MMCy_BASE, pdata);
}

in omap3/4 specific include files.

Let me know if you want to work on this, otherwise I'm also happy to
apply this one as it's already a step forward.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-10-12  7:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11  7:25 Teresa Gámez
2012-10-11  7:25 ` [PATCH 2/2] ARM OMAP: Use wrapper in board files Teresa Gámez
2012-10-11 12:44   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12  7:58 ` Sascha Hauer [this message]
2012-10-12  9:30   ` [PATCH 1/2] ARM OMAP: Create device file Teresa Gamez
2012-10-13 12:10     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121012075835.GG27665@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=t.gamez@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox