From: Sascha Hauer <s.hauer@pengutronix.de>
To: Vicente <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/5] omap4_usbboot_fs: add benchmarking capabilities
Date: Sat, 13 Oct 2012 20:27:46 +0200 [thread overview]
Message-ID: <20121013182746.GC27665@pengutronix.de> (raw)
In-Reply-To: <1350137007-10135-6-git-send-email-vicencb@gmail.com>
On Sat, Oct 13, 2012 at 04:03:27PM +0200, Vicente wrote:
> @@ -166,6 +168,10 @@ int read_asic_id(struct usb_handle *usb)
> struct file_data {
> size_t size;
> void *data;
> +#ifdef BENCHMARK
> + size_t readden;
> + struct timespec opened;
> +#endif
I don't think it's a good idea to add such debug stuff to the
repository. In the end the code gets harder to maintain with
such ifdeffery and there's not much gain in it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-13 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 14:03 [PATCH 0/5] archosg9: improve support for tablet Vicente
2012-10-13 14:03 ` [PATCH 1/5] ArchosG9: changed serial port and env Vicente
2012-10-13 14:03 ` [PATCH 2/5] ARM: add/rename PSR bits to match linux names Vicente
2012-10-13 18:25 ` Sascha Hauer
2012-10-13 14:03 ` [PATCH 3/5] ARM: ensure irqs are disabled at barebox exit Vicente
2012-10-14 8:57 ` Sascha Hauer
2012-10-13 14:03 ` [PATCH 4/5] uimage: improve transfer speed Vicente
2012-10-13 14:03 ` [PATCH 5/5] omap4_usbboot_fs: add benchmarking capabilities Vicente
2012-10-13 18:27 ` Sascha Hauer [this message]
2012-10-13 14:19 ` [PATCH 0/5] archosg9: improve support for tablet Jean-Christophe PLAGNIOL-VILLARD
2012-10-13 14:35 ` vj
2012-10-14 8:12 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013182746.GC27665@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox