Re: [PATCH 00/12] add bus device

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Oct 15, 2012 at 04:49:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 15:21 Mon 15 Oct     , Sascha Hauer wrote:
> > > > --- a/drivers/base/driver.c
> > > > +++ b/drivers/base/driver.c
> > > > @@ -127,6 +127,11 @@ int register_device(struct device_d *new_device)
> > > >  
> > > >  	list_add_tail(&new_device->bus_list, &new_device->bus->device_list);
> > > >  
> > > > +	if (!new_device->parent) {
> > > > +		new_device->parent = &new_device->bus->dev;
> > > > +		dev_add_child(new_device->parent, new_device);
> > > and I was wanting to add global name "barebox" and add everyone under to it
> > > 
> > > I choose to do let the bus manage the child
> > > and to create a device or not
> > 
> > Any idea why we would need this?
> mdio bus as example I was thinking to drop the device as they are always
> attached to a ethernet device
> 
> input bus too
> 
> as example some bus as device specific so no need to add device as the device
> is already here
> 
> I already implement this on arm and so it in the kernel arm too

The patch only makes the new device a child of the bus device when no
parent is set, so it would still be possible to make the phy a child
of the ethernet device.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox