mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Carlo Caione <carlo.caione@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] BCM2835: add support (arch)
Date: Tue, 16 Oct 2012 23:24:16 +0200	[thread overview]
Message-ID: <20121016212416.GC27665@pengutronix.de> (raw)
In-Reply-To: <1350410685-46202-5-git-send-email-carlo.caione@gmail.com>

On Tue, Oct 16, 2012 at 08:04:44PM +0200, Carlo Caione wrote:
> +
> +static struct clk ref_3_clk = {
> +	.rate = 3 * 1000 * 1000,
> +};
> +
> +static struct clk ref_1_clk = {
> +	.rate = 1 * 1000 * 1000,
> +};

Add a 'select COMMON_CLK' to your Kconfig and do a:

	clk_dummy = clk_fixed("dummy", 0);
	clk_ref_3 = clk_fixed("ref3", 3 * 1000 * 1000);
	clk_ref_1 = clk_fixed("ref1", 1 * 1000 * 1000);

Then you can drop your clk code and get a clk_dump command
which you can use to see what clocks you have.

> +static int bcm2835_gpio_init(void)
> +{
> +	add_generic_device("bcm2835-gpio", 0, NULL, BCM2835_GPIO_BASE, 0xB0, IORESOURCE_MEM, NULL);
> +	return 0;
> +}
> +coredevice_initcall(bcm2835_gpio_init);
> +
> +static int bcm2835_clkdev_init(void)
> +{
> +	clkdev_add_table(clocks_lookups, ARRAY_SIZE(clocks_lookups));
> +	return 0;
> +}
> +postcore_initcall(bcm2835_clkdev_init);
> +
> +static int bcm2835_clocksource_init(void)
> +{
> +	add_generic_device("bcm2835-cs", DEVICE_ID_SINGLE, NULL, BCM2835_ST_BASE, 0x1C, IORESOURCE_MEM, NULL);
> +	return 0;
> +}
> +coredevice_initcall(bcm2835_clocksource_init);
> +

Please consolidate the initcalls. A single function for the three above
is enough.

> +void bcm2835_register_uart(void)

Please add the UART index to the function name.

> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

The address is wrong. Please remove this paragraph completly

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-10-16 21:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 18:04 [PATCH 0/5] BCM2835/Raspberry-Pi support Carlo Caione
2012-10-16 18:04 ` [PATCH 1/5] BCM2835: add clocksource driver Carlo Caione
2012-10-16 18:04 ` [PATCH 2/5] BCM2835: add gpio driver Carlo Caione
2012-10-16 21:09   ` Sascha Hauer
2012-10-16 18:04 ` [PATCH 3/5] ARM1176: add support Carlo Caione
2012-10-16 18:04 ` [PATCH 4/5] BCM2835: add support (arch) Carlo Caione
2012-10-16 21:24   ` Sascha Hauer [this message]
2012-10-17  6:51     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-17  7:01       ` Sascha Hauer
2012-10-17  7:25         ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-17  8:31           ` Carlo Caione
2012-10-17 21:00             ` Sascha Hauer
2012-10-17 22:27     ` Carlo Caione
2012-10-18  7:02       ` Sascha Hauer
2012-10-16 18:04 ` [PATCH 5/5] Raspberry-Pi: add support (board) Carlo Caione
  -- strict thread matches above, loose matches on Subject: below --
2012-10-18 19:42 [PATCH 0/5] BCM2835/Raspberry-Pi support Carlo Caione
2012-10-18 19:42 ` [PATCH 4/5] BCM2835: add support (arch) Carlo Caione
2012-10-13 14:00 [PATCH 0/5] BCM2835/Raspberry-Pi support Carlo Caione
2012-10-13 14:00 ` [PATCH 4/5] BCM2835: add support (arch) Carlo Caione
2012-10-13 11:22 [PATCH 0/5] BCM2835/Raspberry-Pi Carlo Caione
2012-10-13 11:23 ` [PATCH 4/5] BCM2835: add support (arch) Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016212416.GC27665@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=carlo.caione@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox