Re: [PATCH] net phy: poll for a link

[Sascha Hauer <s.hauer@pengutronix.de>]

Jean-Christophe,

On Thu, Oct 25, 2012 at 08:37:11AM +0200, Sascha Hauer wrote:
> On Wed, Oct 24, 2012 at 08:33:59PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 20:06 Wed 24 Oct     , Sascha Hauer wrote:
> > > Since we have phylib we have no instance which polls for a link. This
> > > means that network boot often bails out after a powercycle or phy reset.
> > > This changes the link status behaviour to:
> > > 
> > > - Always check for a link if the last link test was unsuccesful
> > > - If the last check was succesful, check for a link when the last
> > >   check is longer than 5 seconds ago
> > > - Try to get a link for 5 seconds.
> > 5 seconds is too long
> > 
> > and check the link is wrong you need to check the autoneg
> > the link may be down because no cable
> > 
> > Here we need to check the autoneg is finished
> > and the phy is up
> > 
> > so use phy_aneg_done and genphy_config_aneg is for this
> 
> phy_aneg_done is not exported and genphy_config_aneg is for phy driver
> use only.
> 
> Could you prepare a patch for this? You insisted hard on getting this
> merged in the first place and seem to know what has to be done.

Will you prepare a patch for this? This is really something I want to
have solved before the next release and right now I do not understand
your proposed solution to this.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox