From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1 v2] gpio: move gpio_is_valid to gpio.h
Date: Mon, 29 Oct 2012 08:43:24 +0100 [thread overview]
Message-ID: <20121029074324.GK1641@pengutronix.de> (raw)
In-Reply-To: <1351369365-21395-1-git-send-email-plagnioj@jcrosoft.com>
On Sat, Oct 27, 2012 at 10:22:45PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> gpio < 0 means invalid too
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
What we really should do is to get rid of is the inclusion of
mach/gpio.h, asm/gpio.h from gpio.h. I began to prepare a patch for
this, but it has to wait some time due to other things to do.
Applied, thanks
Sascha
> ---
> send right version
>
> Best Regards,
> J.
> drivers/gpio/gpio.c | 9 ---------
> include/asm-generic/gpio.h | 11 +++++++++++
> 2 files changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio.c b/drivers/gpio/gpio.c
> index 6ad8d27..042a062 100644
> --- a/drivers/gpio/gpio.c
> +++ b/drivers/gpio/gpio.c
> @@ -4,17 +4,8 @@
>
> static LIST_HEAD(chip_list);
>
> -#define ARCH_NR_GPIOS 256
> -
> static struct gpio_chip *gpio_desc[ARCH_NR_GPIOS];
>
> -static int gpio_is_valid(unsigned gpio)
> -{
> - if (gpio < ARCH_NR_GPIOS)
> - return 1;
> - return 0;
> -}
> -
> void gpio_set_value(unsigned gpio, int value)
> {
> struct gpio_chip *chip = gpio_desc[gpio];
> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> index 1997888..c2e7a5d 100644
> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
> @@ -1,6 +1,17 @@
> #ifndef __ASM_GENERIC_GPIO_H
> #define __ASM_GENERIC_GPIO_H
>
> +#define ARCH_NR_GPIOS 256
> +
> +static inline int gpio_is_valid(int gpio)
> +{
> + if (gpio < 0)
> + return 0;
> + if (gpio < ARCH_NR_GPIOS)
> + return 1;
> + return 0;
> +}
> +
> void gpio_set_value(unsigned gpio, int value);
> int gpio_get_value(unsigned gpio);
> int gpio_direction_output(unsigned gpio, int value);
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-10-29 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 20:10 [For next PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:22 ` [PATCH 1/1 v2] " Jean-Christophe PLAGNIOL-VILLARD
2012-10-29 7:43 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029074324.GK1641@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox