mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] clock: introduce non interruptible timeout
Date: Mon, 29 Oct 2012 08:45:52 +0100	[thread overview]
Message-ID: <20121029074552.GL1641@pengutronix.de> (raw)
In-Reply-To: <1351368225-19521-1-git-send-email-plagnioj@jcrosoft.com>

On Sat, Oct 27, 2012 at 10:03:41PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> is_non_timeout call poller_call if the timeout is >= 100us
> 
> but on 1-wire bus we need to wait 500us and not more than 930us
> for the bus reset. So if the poller_call is caller we can not guarantee it.
> 
> So for this introduce is_non_interruptible_timeout than we only wait.
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/clock.c  |   14 ++++++++++----
>  include/clock.h |    1 +
>  2 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/common/clock.c b/common/clock.c
> index 8adbeaf..a358b78 100644
> --- a/common/clock.c
> +++ b/common/clock.c
> @@ -135,16 +135,22 @@ uint32_t clocksource_hz2mult(uint32_t hz, uint32_t shift_constant)
>          return (uint32_t)tmp;
>  }
>  
> -int is_timeout(uint64_t start_ns, uint64_t time_offset_ns)
> +int is_non_interruptible_timeout(uint64_t start_ns, uint64_t time_offset_ns)

Please rename to is_timeout_non_interruptible.

Otherwise ok.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-10-29  7:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 19:59 [PATCH 0/5] add 1-wire support Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:03 ` [PATCH 1/5] clock: introduce non interruptible timeout Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:03   ` [PATCH 2/5] add 1-wire support Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:03   ` [PATCH 3/5] 1-wire: add gpio bus Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:03   ` [PATCH 4/5] 1-wire: add ds2431 support Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:03   ` [PATCH 5/5] 1-wire: add ds2433 support Jean-Christophe PLAGNIOL-VILLARD
2012-10-29  7:45   ` Sascha Hauer [this message]
2012-10-29 12:46 [PATCH 0/5 v2] add 1-wire support Jean-Christophe PLAGNIOL-VILLARD
2012-10-29 13:02 ` [PATCH 1/5] clock: introduce non interruptible timeout Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121029074552.GL1641@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox