From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console
Date: Tue, 30 Oct 2012 09:44:23 +0100 [thread overview]
Message-ID: <20121030084423.GD29599@game.jcrosoft.org> (raw)
In-Reply-To: <20121029205503.GX24458@pengutronix.de>
On 21:55 Mon 29 Oct , Sascha Hauer wrote:
> On Sun, Oct 28, 2012 at 10:15:10AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > common/console.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Dropped this one as it breaks most defconfigs with:
>
> common/console.c: In function 'console_std_set':
> common/console.c:90:3: warning: implicit declaration of function 'PUTS_LL' [-Wimplicit-function-declaration]
> common/built-in.o: In function `console_std_set':
> bootargs.c:(.text.console_std_set+0xf8): undefined reference to `PUTS_LL'
> bootargs.c:(.text.console_std_set+0x104): undefined reference to `PUTS_LL'
> bootargs.c:(.text.console_std_set+0x10c): undefined reference to `PUTS_LL'
I try here on next no break
PUTS_LL is not defined if DEBUG_LL is not enabled
did you put in over the previous patch I send for the debug_ll and console
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-30 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 9:15 [PATCH 1/2] debug_ll: use const char* for PUTS_LL Jean-Christophe PLAGNIOL-VILLARD
2012-10-28 9:15 ` [PATCH 2/2] console: display Switch to console [csxx] when switching from debug_ll to real console Jean-Christophe PLAGNIOL-VILLARD
2012-10-29 20:55 ` Sascha Hauer
2012-10-30 8:44 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-30 9:26 ` Sascha Hauer
2012-10-29 7:39 ` [PATCH 1/2] debug_ll: use const char* for PUTS_LL Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030084423.GD29599@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox