mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work@mail.ru>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v4 1/3] ARM: Add initial support for CLPS711X architecture
Date: Fri, 2 Nov 2012 14:35:03 +0400	[thread overview]
Message-ID: <20121102143503.c0daefb7b5f19478daf95720@mail.ru> (raw)
In-Reply-To: <20121102102429.GR29599@game.jcrosoft.org>

On Fri, 2 Nov 2012 11:24:29 +0100
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:

...
> > +static int clocks_init(void)
> > +{
> > +	int osc, ext, pll, cpu, timer;
> > +	u32 tmp;
> > +
> > +	osc = 3686400;
> > +	ext = 13000000;
> > +
> > +	tmp = readl(PLLR) >> 24;
> > +	if (tmp)
> > +		pll = (osc * tmp) / 2;
> > +	else
> > +		pll = 73728000; /* Default value for old CPUs */
> > +
> > +	tmp = readl(SYSFLG2);
> > +	if (tmp & SYSFLG2_CKMODE) {
> > +		cpu = ext;
> > +		bus_clk.rate = cpu;
> > +	} else {
> > +		cpu = pll;
> > +		if (cpu >= 36864000)
> > +			bus_clk.rate = cpu / 2;
> > +		else
> > +			bus_clk.rate = 36864000 / 2;
> > +	}
> > +
> > +	uart_clk.rate = bus_clk.rate / 10;
> this wrong split clocksource driver and clocks init
> 
> the clock driver will have to go to drivers/clocksource
I remember about it, and as soon as clocksource go into master, I will
make the necessary modifications.

-- 
Alexander Shiyan <shc_work@mail.ru>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-11-02 10:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  9:17 Alexander Shiyan
2012-11-02  9:17 ` [PATCH v4 2/3] ARM: clps711x: Add serial driver Alexander Shiyan
2012-11-02  9:17 ` [PATCH v4 3/3] ARM: clps711x: Add generic board support (CLEP7212) Alexander Shiyan
2012-11-02 10:24 ` [PATCH v4 1/3] ARM: Add initial support for CLPS711X architecture Jean-Christophe PLAGNIOL-VILLARD
2012-11-02 10:35   ` Alexander Shiyan [this message]
2012-11-02 10:25 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121102143503.c0daefb7b5f19478daf95720@mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox