mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] mx53-loco: fix phy reset
Date: Thu, 15 Nov 2012 12:27:46 +0100	[thread overview]
Message-ID: <20121115112746.GA10369@pengutronix.de> (raw)
In-Reply-To: <1352976064-18544-1-git-send-email-plagnioj@jcrosoft.com>

On Thu, Nov 15, 2012 at 11:41:04AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> the phy reset neet to be done before the fec driver is registered
> as we accesst the phy at the fec probe time

I spotted that aswell in the meantime. Applied, thanks

Sascha

> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/boards/freescale-mx53-loco/board.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boards/freescale-mx53-loco/board.c b/arch/arm/boards/freescale-mx53-loco/board.c
> index 45c05c2..216d26a 100644
> --- a/arch/arm/boards/freescale-mx53-loco/board.c
> +++ b/arch/arm/boards/freescale-mx53-loco/board.c
> @@ -187,6 +187,7 @@ static int loco_devices_init(void)
>  {
>  
>  	imx53_iim_register_fec_ethaddr();
> +	loco_fec_reset();
>  	imx53_add_fec(&fec_info);
>  	imx53_add_mmc0(&loco_sd1_data);
>  	imx53_add_mmc2(&loco_sd3_data);
> @@ -196,8 +197,6 @@ static int loco_devices_init(void)
>  	if (IS_ENABLED(CONFIG_USB_EHCI))
>  		loco_ehci_init();
>  
> -	loco_fec_reset();
> -
>  	set_silicon_rev(imx_silicon_revision());
>  
>  	armlinux_set_bootparams((void *)0x70000100);
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-11-15 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 10:41 Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 11:27 ` Sascha Hauer [this message]
2012-11-15 11:51 Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 11:52 ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121115112746.GA10369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox