* [PATCH 1/1] mx53-loco: fix phy reset
@ 2012-11-15 11:51 Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 11:52 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-11-15 11:51 UTC (permalink / raw)
To: barebox
the phy reset neet to be done before the fec driver is registered
as we accesst the phy at the fec probe time
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
arch/arm/boards/freescale-mx53-loco/board.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boards/freescale-mx53-loco/board.c b/arch/arm/boards/freescale-mx53-loco/board.c
index 45c05c2..216d26a 100644
--- a/arch/arm/boards/freescale-mx53-loco/board.c
+++ b/arch/arm/boards/freescale-mx53-loco/board.c
@@ -187,6 +187,7 @@ static int loco_devices_init(void)
{
imx53_iim_register_fec_ethaddr();
+ loco_fec_reset();
imx53_add_fec(&fec_info);
imx53_add_mmc0(&loco_sd1_data);
imx53_add_mmc2(&loco_sd3_data);
@@ -196,8 +197,6 @@ static int loco_devices_init(void)
if (IS_ENABLED(CONFIG_USB_EHCI))
loco_ehci_init();
- loco_fec_reset();
-
set_silicon_rev(imx_silicon_revision());
armlinux_set_bootparams((void *)0x70000100);
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] mx53-loco: fix phy reset
2012-11-15 11:51 [PATCH 1/1] mx53-loco: fix phy reset Jean-Christophe PLAGNIOL-VILLARD
@ 2012-11-15 11:52 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-11-15 11:52 UTC (permalink / raw)
To: barebox
On 12:51 Thu 15 Nov , Jean-Christophe PLAGNIOL-VILLARD wrote:
> the phy reset neet to be done before the fec driver is registered
> as we accesst the phy at the fec probe time
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
forget this one this was send twice
Best Regards,
J.
> arch/arm/boards/freescale-mx53-loco/board.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boards/freescale-mx53-loco/board.c b/arch/arm/boards/freescale-mx53-loco/board.c
> index 45c05c2..216d26a 100644
> --- a/arch/arm/boards/freescale-mx53-loco/board.c
> +++ b/arch/arm/boards/freescale-mx53-loco/board.c
> @@ -187,6 +187,7 @@ static int loco_devices_init(void)
> {
>
> imx53_iim_register_fec_ethaddr();
> + loco_fec_reset();
> imx53_add_fec(&fec_info);
> imx53_add_mmc0(&loco_sd1_data);
> imx53_add_mmc2(&loco_sd3_data);
> @@ -196,8 +197,6 @@ static int loco_devices_init(void)
> if (IS_ENABLED(CONFIG_USB_EHCI))
> loco_ehci_init();
>
> - loco_fec_reset();
> -
> set_silicon_rev(imx_silicon_revision());
>
> armlinux_set_bootparams((void *)0x70000100);
> --
> 1.7.10.4
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] mx53-loco: fix phy reset
2012-11-15 10:41 Jean-Christophe PLAGNIOL-VILLARD
@ 2012-11-15 11:27 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2012-11-15 11:27 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Thu, Nov 15, 2012 at 11:41:04AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> the phy reset neet to be done before the fec driver is registered
> as we accesst the phy at the fec probe time
I spotted that aswell in the meantime. Applied, thanks
Sascha
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> arch/arm/boards/freescale-mx53-loco/board.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boards/freescale-mx53-loco/board.c b/arch/arm/boards/freescale-mx53-loco/board.c
> index 45c05c2..216d26a 100644
> --- a/arch/arm/boards/freescale-mx53-loco/board.c
> +++ b/arch/arm/boards/freescale-mx53-loco/board.c
> @@ -187,6 +187,7 @@ static int loco_devices_init(void)
> {
>
> imx53_iim_register_fec_ethaddr();
> + loco_fec_reset();
> imx53_add_fec(&fec_info);
> imx53_add_mmc0(&loco_sd1_data);
> imx53_add_mmc2(&loco_sd3_data);
> @@ -196,8 +197,6 @@ static int loco_devices_init(void)
> if (IS_ENABLED(CONFIG_USB_EHCI))
> loco_ehci_init();
>
> - loco_fec_reset();
> -
> set_silicon_rev(imx_silicon_revision());
>
> armlinux_set_bootparams((void *)0x70000100);
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] mx53-loco: fix phy reset
@ 2012-11-15 10:41 Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 11:27 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-11-15 10:41 UTC (permalink / raw)
To: barebox
the phy reset neet to be done before the fec driver is registered
as we accesst the phy at the fec probe time
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
arch/arm/boards/freescale-mx53-loco/board.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boards/freescale-mx53-loco/board.c b/arch/arm/boards/freescale-mx53-loco/board.c
index 45c05c2..216d26a 100644
--- a/arch/arm/boards/freescale-mx53-loco/board.c
+++ b/arch/arm/boards/freescale-mx53-loco/board.c
@@ -187,6 +187,7 @@ static int loco_devices_init(void)
{
imx53_iim_register_fec_ethaddr();
+ loco_fec_reset();
imx53_add_fec(&fec_info);
imx53_add_mmc0(&loco_sd1_data);
imx53_add_mmc2(&loco_sd3_data);
@@ -196,8 +197,6 @@ static int loco_devices_init(void)
if (IS_ENABLED(CONFIG_USB_EHCI))
loco_ehci_init();
- loco_fec_reset();
-
set_silicon_rev(imx_silicon_revision());
armlinux_set_bootparams((void *)0x70000100);
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-15 11:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-15 11:51 [PATCH 1/1] mx53-loco: fix phy reset Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 11:52 ` Jean-Christophe PLAGNIOL-VILLARD
-- strict thread matches above, loose matches on Subject: below --
2012-11-15 10:41 Jean-Christophe PLAGNIOL-VILLARD
2012-11-15 11:27 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox