Re: [PATCH 1/1] mx53 loco: enable smsc phy driver

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Nov 15, 2012 at 02:48:23PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:40 Thu 15 Nov     , Sascha Hauer wrote:
> > On Thu, Nov 15, 2012 at 12:56:02PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > >  arch/arm/configs/freescale_mx53_loco_defconfig |    1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > We're getting closer \o/
> > 
> > With this the LOCO correctly waits for a link, unfortunately during
> > board init time. This is due to:
> > 
> > commit 3a17af33c01fd066ab3939c8218037c87ba26eed
> > Author: Sascha Hauer <s.hauer@pengutronix.de>
> > Date:   Fri Oct 26 16:16:54 2012 +0200
> > 
> >     net fec: connect phy at probe time
> >     
> >     Several i.MX boards (all i.MX6 boards) need to do some adjustments
> >     to phy registers. If barebox itself does not use network, networking
> >     won't work in the kernel if the kernel does not have the fixups. Connect
> >     the phy at probe time so that these tweaks are done during probe so that
> >     the kernel works without phy register tweaks. Also this has the effect
> >     that the phy device is present and introspectable without doing fake
> >     network transfers beforehand.
> > 
> > We could revert it which fixes things for the LOCO, but then we also
> > lose the phy fixups which this commit intentionally pushed to probe
> > time.
> > 
> > It would be nice to separate phy registration from actually waiting for
> > a link. I find it rather inconvenient anyway that the phy device pops
> > up during the first network transfer.
> 
> so we need to introduce a phy_start
> 
> that start the check of the link
> 
> but I think the kernel need to its own fixup and do not relay on the booloader
> to do it for him

I agree, the kernel should not depend on the bootloader, still it's
convenient that kernels without support for this specific board will
just work. I can live with reverting the patch for this release though.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox