From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: shouldn't asm-generic/barebox.lds.h be arch-independent?
Date: Mon, 19 Nov 2012 09:32:21 +0100 [thread overview]
Message-ID: <20121119083221.GA10369@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1211181326250.704@oneiric>
On Sun, Nov 18, 2012 at 01:31:06PM -0500, Robert P. J. Day wrote:
>
> there is one more oddity(?) with the way the linker "lds" files are
> set up. if i read this correctly (and i could be wrong), here's
> arch/x86/lib/barebox.lds.S:
>
> #undef i386
> #include <asm-generic/barebox.lds.h>
>
> which gets us to that included file, which contains:
>
> #if defined CONFIG_ARCH_IMX25 || \
> defined CONFIG_ARCH_IMX35 || \
> defined CONFIG_ARCH_IMX51 || \
> defined CONFIG_ARCH_IMX53 || \
> defined CONFIG_ARCH_IMX6 || \
> defined CONFIG_X86 || \ <-- that will be true, correct?
> defined CONFIG_ARCH_EP93XX
> #include <mach/barebox.lds.h>
> #endif
Instead of having this the users should include asm/barebox.lds.h which
then in turn includes asm-generic/barebox.lds.h.
>
> which finally takes us to
> arch/x86/mach-i386/include/mach/barebox.lds.h, which is nothing more
> than a collection of macro definitions. there's no "pre-image"
> content to be incorporated into the final image -- it's just
> preprocessor content. so why isn't all that simply at the beginning
> of the main x86 barebox.lds.S file?
I don't know. It should probably be moved there.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-11-19 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 17:52 Robert P. J. Day
2012-11-18 18:21 ` Antony Pavlov
2012-11-18 18:24 ` Robert P. J. Day
2012-11-18 18:31 ` Robert P. J. Day
2012-11-19 8:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119083221.GA10369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox