From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH] arm lib: Remove redundant boot usage info from boot[uz].c
Date: Mon, 19 Nov 2012 10:14:43 +0100 [thread overview]
Message-ID: <20121119091443.GE10369@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1211180836390.17973@oneiric>
On Sun, Nov 18, 2012 at 08:39:51AM -0500, Robert P. J. Day wrote:
>
> There is no need to add the command name to the "usage" info when
> defining a command.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Applied, thanks
Sascha
>
> ---
>
> fairly sure the command name is superfluous in the usage string,
> yes?
>
> diff --git a/arch/arm/lib/bootu.c b/arch/arm/lib/bootu.c
> index 0d155cb..75e0de3 100644
> --- a/arch/arm/lib/bootu.c
> +++ b/arch/arm/lib/bootu.c
> @@ -36,7 +36,7 @@ static const __maybe_unused char cmd_bootu_help[] =
>
> BAREBOX_CMD_START(bootu)
> .cmd = do_bootu,
> - .usage = "bootu - start a raw linux image",
> + .usage = "start a raw linux image",
> BAREBOX_CMD_HELP(cmd_bootu_help)
> BAREBOX_CMD_END
>
> diff --git a/arch/arm/lib/bootz.c b/arch/arm/lib/bootz.c
> index f069127..9f5b3b4 100644
> --- a/arch/arm/lib/bootz.c
> +++ b/arch/arm/lib/bootz.c
> @@ -133,7 +133,7 @@ static const __maybe_unused char cmd_bootz_help[] =
>
> BAREBOX_CMD_START(bootz)
> .cmd = do_bootz,
> - .usage = "bootz - start a zImage",
> + .usage = "start a zImage",
> BAREBOX_CMD_HELP(cmd_bootz_help)
> BAREBOX_CMD_END
>
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-11-19 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 13:39 Robert P. J. Day
2012-11-19 9:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119091443.GE10369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox