mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: start-pbl.c: unificate path to lib/decompress_*.c
Date: Tue, 20 Nov 2012 08:24:22 +0100	[thread overview]
Message-ID: <20121120072422.GY10369@pengutronix.de> (raw)
In-Reply-To: <CAA4bVAEhKuc3FdpqV5VNxXw7PKw9k0Qd-Ssnjpxjru6=A37Ncw@mail.gmail.com>

On Mon, Nov 19, 2012 at 04:37:38PM +0400, Antony Pavlov wrote:
> >> The files decompress_inflate.c and decompress_unlzo.c are in the same
> >> directory. Why we use different prefixes to address them?
> >
> > I understand the patch and why it's correct. I just wondered why it
> > works correctly without this patch.
> >
> > ls arch/arm/cpu/../../../../lib/decompress_inflate.c
> > ls: cannot access arch/arm/cpu/../../../../lib/decompress_inflate.c: No such file or directory
> >
> > This is correct, we only have to go three directories up. Still it
> > compiles fine.
> 
> IMHO we use very many '-I' options when running C compiler. Some of
> them make possible to include the decompres-related files with the
> '../../../../' prefix,
> the other ones make possible to use '../../../'.

I wasn't aware that files included with "" also evaluate the -i options.

Applied, thanks.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-11-20  7:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17  9:25 ARM: pbl: short patches Antony Pavlov
2012-11-17  9:25 ` [PATCH 1/3] ARM: pbl: remove zbarebox.map during 'make clean' Antony Pavlov
2012-11-17  9:26 ` [PATCH 2/3] ARM: start-pbl.c: make errorfn() static Antony Pavlov
2012-11-17  9:26 ` [PATCH 3/3] ARM: start-pbl.c: unificate path to lib/decompress_*.c Antony Pavlov
2012-11-18 15:29   ` Antony Pavlov
2012-11-19 10:30   ` Sascha Hauer
2012-11-19 11:34     ` Antony Pavlov
2012-11-19 12:07       ` Sascha Hauer
2012-11-19 12:37         ` Antony Pavlov
2012-11-20  7:24           ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121120072422.GY10369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox