mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] read cfi device id according the bus width
Date: Thu, 22 Nov 2012 07:38:26 +0100	[thread overview]
Message-ID: <20121122063826.GS8327@game.jcrosoft.org> (raw)
In-Reply-To: <20121122062616.GD3022@greatfirst.com>

On 14:26 Thu 22 Nov     , 张忠山 wrote:
> In message <20121122061438.GR8327@game.jcrosoft.org> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 14:01 Thu 22 Nov     , 张忠山 wrote:
> > > Signed-off-by: 张忠山 <zzs213@126.com>
> > > ---
> > >  drivers/nor/cfi_flash_amd.c |    7 +++++--
> > >  1 files changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/nor/cfi_flash_amd.c b/drivers/nor/cfi_flash_amd.c
> > > index 45c59b9..3ab4be0 100644
> > > --- a/drivers/nor/cfi_flash_amd.c
> > > +++ b/drivers/nor/cfi_flash_amd.c
> > > @@ -62,8 +62,11 @@ static void amd_read_jedec_ids (struct flash_info *info)
> > >  	udelay(1000); /* some flash are slow to respond */
> > >
> > >  	info->manufacturer_id = jedec_read_mfr(info);
> > > -	info->device_id = flash_read_uchar (info,
> > > -					FLASH_OFFSET_DEVICE_ID);
> > > +	if(info->chipwidth == FLASH_CFI_BY16)
> > > +		info->device_id = flash_read16(flash_make_addr(info, 0, FLASH_OFFSET_DEVICE_ID));
> > > +	else
> > > +		info->device_id = flash_read_uchar (info,
> > > +						FLASH_OFFSET_DEVICE_ID);
> >
> > make this global with all with support
> > as don in linux
> >
> > as this is valid for amd and intel and st
> >
> Does this mean cp this code to the function
> drivers/nor/cfi_flash_intel.c:intel_read_jedec_ids() ?
you can not as the reset is flash depedent

just factorise teh device_id read

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-11-22  6:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  6:01 张忠山
2012-11-22  6:14 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-22  6:26   ` 张忠山
2012-11-22  6:38     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-22  6:49 张忠山
2012-11-22  7:25 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-22  8:06   ` 张忠山
2012-11-22  1:48 张忠山
2012-11-22  5:46 ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121122063826.GS8327@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox