From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 1/3] MIPS: add pre-bootloader (pbl) image support
Date: Mon, 26 Nov 2012 09:05:24 +0100 [thread overview]
Message-ID: <20121126080524.GU10369@pengutronix.de> (raw)
In-Reply-To: <CAA4bVAFgwUzppRGvq1SAnSYqwOA3pXKmihdOZ=6tO=vAKuNaoQ@mail.gmail.com>
On Sat, Nov 24, 2012 at 07:45:01PM +0400, Antony Pavlov wrote:
> Sorry for delay.
>
> On 20 November 2012 11:59, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Sat, Nov 17, 2012 at 04:10:37PM +0400, Antony Pavlov wrote:
> >> This patch is based on ARM pbl support and allows
> >> creating a pre-bootloader binary for compressed image.
> >>
> >> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> >> ---
> >> + .macro ADR rd label temp
> >> + .set push
> >> + .set noreorder
> >> + move \temp, ra # preserve ra beforehand
> >> + bal _pc
> >> + nop
> >
> > This file contains some whitespace damages you could cleanup along the
> > way.
>
> If you are about this fragment
> >> + bal _pc
> >> + nop
>
> then there is no whitespace damage --- the 'nop' instruction is in the
> delay slot of the branch instruction (bal).
Ok, forget this one. I'm not familiar with Mips assembly.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-11-26 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 12:10 [RFC 0/3] " Antony Pavlov
2012-11-17 12:10 ` [RFC 1/3] " Antony Pavlov
2012-11-20 7:59 ` Sascha Hauer
2012-11-24 15:45 ` Antony Pavlov
2012-11-26 8:05 ` Sascha Hauer [this message]
2012-11-17 12:10 ` [RFC 2/3] MIPS: boot: realize _start in C Antony Pavlov
2012-11-20 7:58 ` Sascha Hauer
2012-11-24 16:18 ` Antony Pavlov
2012-11-17 12:10 ` [RFC 3/3] MIPS: qemu-malta_defconfig: use pbl Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126080524.GU10369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox