mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox <barebox@lists.infradead.org>
Subject: Re: kbuild can't build foo/xxx.o
Date: Mon, 3 Dec 2012 11:00:43 +0100	[thread overview]
Message-ID: <20121203100043.GN10369@pengutronix.de> (raw)
In-Reply-To: <20121203095150.GA20812@greatfirst.com>

On Mon, Dec 03, 2012 at 05:51:50PM +0800, 张忠山 wrote:
> kbuild in barebox can't built when
> 
> obj-y += foo/xxx.o
> 
> But in kernel, It's OK
> 
> Maybe it should:
> 
> ----------------------------------------------------------
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index cb46db2..14e471d 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -55,10 +55,10 @@ multi-objs-y := $(foreach m, $(multi-used-y), $($(m:.o=-objs)) $($(m:.o=-y)))
>  multi-objs-m := $(foreach m, $(multi-used-m), $($(m:.o=-objs)) $($(m:.o=-y)))
>  multi-objs   := $(multi-objs-y) $(multi-objs-m)
> 
> -# $(subdir-obj-y) is the list of objects in $(obj-y) which do not live
> -# in the local directory
> -__subdir-obj-y := $(foreach o,$(pbl-y),$(if $(filter-out $(o),$(notdir $(o))),$(o)))
> -subdir-obj-y := $(foreach o,$(obj-y),$(if $(filter-out $(o),$(notdir $(o))),$(o)))
> +# $(subdir-obj-y) is the list of objects in $(obj-y) which uses dir/ to
> +# tell kbuild to descend
> +__subdir-obj-y := $(filter %/built-in-pbl.o, $(pbl-y))
> +subdir-obj-y := $(filter %/built-in.o, $(obj-y))
>  subdir-obj-y += $(__subdir-obj-y)
> 
>  # $(obj-dirs) is a list of directories that contain object files

Seems you have that from the Kernel. Looks fine. Can you send a formal
patch with you Signed-off and also an explanation on which original
Kernel commit this is based on?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-12-03 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03  9:51 张忠山
2012-12-03 10:00 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121203100043.GN10369@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox