From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: phy: mdio_bus: fix inverted logic in mdio_bus_match
Date: Tue, 4 Dec 2012 22:11:55 +0100 [thread overview]
Message-ID: <20121204211155.GI8327@game.jcrosoft.org> (raw)
In-Reply-To: <1354641636-23483-1-git-send-email-jlu@pengutronix.de>
On 18:20 Tue 04 Dec , Jan Luebbe wrote:
> The bus match functions return 0 on success.
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
already fix in next
Best Regards,
J.
> ---
> drivers/net/phy/mdio_bus.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 9424179..aaac559 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -126,7 +126,11 @@ static int mdio_bus_match(struct device_d *dev, struct driver_d *drv)
> struct phy_device *phydev = to_phy_device(dev);
> struct phy_driver *phydrv = to_phy_driver(drv);
>
> - return ((phydrv->phy_id & phydrv->phy_id_mask) ==
> + pr_debug("%s: trying to match driver %s: (0x%08x & 0x%08x) ~ 0x%08x\n",
> + dev->name, drv->name,
> + phydev->phy_id, phydrv->phy_id_mask, phydrv->phy_id);
> +
> + return ((phydrv->phy_id & phydrv->phy_id_mask) !=
> (phydev->phy_id & phydrv->phy_id_mask));
> }
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-12-04 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 17:20 Jan Luebbe
2012-12-04 21:11 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204211155.GI8327@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=jlu@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox